[Bug-gnu-arch] [bug #6059] support for per-directory categorization regexps

[nobody]

=================== BUG #6059: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=6059&group_id=4899

Changes by: Robert Collins <address@hidden>
Date: Sat 11/08/2003 at 10:59 (GMT)

------------------ Additional Follow-up Comments ----------------------------
Merged into address@hidden/tla--integration--1.1--patch-2 and -3. On a code 
style note, it appears to me that the evaluation of the per dir and global 
regexs may be 'wrong'.



i.e. currently you evaluate:

dir, global X, for X in excludes, junk, backup etc etc.



This means that a per dir regex that is less strict for excludes cannot 
override a more strict global excludes (and likewise for backup, source etc).



So, I suggest that you change the order:

dir X for all X, followed by global X, for all X.



This could be neatly implemented via a subroutine that takes a pointer to the 
regexps struct, extracted appropriately from arch_inventory_traversal_internal.



I've merged your code anyway, to give folk 'out there' a starting point for 
experimentation.





=================== BUG #6059: FULL BUG SNAPSHOT ===================


Submitted by: rfarine                 Project: GNU arch -- a revision control 
system
Submitted on: Sun 10/19/2003 at 23:21
Category:  tla                        Severity:  5 - Major                  
Bug Group:  small feature idea        Resolution:  None                     
Status:  Open                         Release:  
address@hidden/tla--devo--1.1--patch-188
Fixed Release:                        Merge Request?:  yes -- merge from my 
archive
Your Archive Name:  address@hidden Archive Location:                
Assigned to:  None                    

Summary:  support for per-directory categorization regexps

Original Submission:  address@hidden

  tla

    tla--rnf

      tla--rnf--1.1



        patch-8    (simple changeset)

          support for per-directory categorization regexps





A file named '.arch-inventory' can locally override the

common categorization regexps for entries in the directory

which contains it by redefining a subset or all of the

regexps defined in '=tagging-method' (exclude, junk,

backup, unrecognized, source).



While processing a directory with such a file, the

inventory process first tries all of the locally redefined

regexps and, if no one matches, it falls back to the common

regexps.



Follow-up Comments
*******************

-------------------------------------------------------
Date: Sat 11/08/2003 at 10:59       By: robertc
Merged into address@hidden/tla--integration--1.1--patch-2 and -3. On a code 
style note, it appears to me that the evaluation of the per dir and global 
regexs may be 'wrong'.



i.e. currently you evaluate:

dir, global X, for X in excludes, junk, backup etc etc.



This means that a per dir regex that is less strict for excludes cannot 
override a more strict global excludes (and likewise for backup, source etc).



So, I suggest that you change the order:

dir X for all X, followed by global X, for all X.



This could be neatly implemented via a subroutine that takes a pointer to the 
regexps struct, extracted appropriately from arch_inventory_traversal_internal.



I've merged your code anyway, to give folk 'out there' a starting point for 
experimentation.



-------------------------------------------------------
Date: Sun 11/02/2003 at 01:48       By: rfarine
Merge upstream changes, provide inventory ids for

".arch-inventory" files and add a test case.



address@hidden

http://213.200.230.54/{pubarch.v2}/address@hidden/2003

  tla

    tla--rnf

      tla--rnf--1.1



        patch-8    (simple changeset)

          support for per-directory categorization regexps



        patch-9    (simple changeset)

          merge from address@hidden



        patch-10    (simple changeset)

          name inventory ids for ".arch-inventory" files



        patch-11    (simple changeset)

          test case for per-directory regexps






CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=6059&group_id=4899

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/