[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-gnu-arch] [bug #4953] minor bugs in cmd-archive-mirror
From: |
nobody |
Subject: |
[Bug-gnu-arch] [bug #4953] minor bugs in cmd-archive-mirror |
Date: |
Sat, 08 Nov 2003 20:04:38 -0500 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031020 Debian/1.5-1 |
=================== BUG #4953: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4953&group_id=4899
Changes by: Jason McCarty <address@hidden>
Date: Sun 11/09/03 at 01:04 (GMT)
------------------ Additional Follow-up Comments ----------------------------
I updated my branch of tla after all this time, since I'm still seeing this
apparent bug:
$ tla push-mirror tla--devo
/tmp/dists--devo--1.0--patch-49/src/tla/libarch/archives.c:36:botched invariant
arch_valid_archive_name (archive_name)
PANIC: exiting on botched invariant
My branch allows you to pass just the limit while treating the default archive
as MINE, which IMO is useful and matches the description more accurately.
The revision is at address@hidden/tla--devo--1.1--patch-9
http://complex.dyndns.org:8000/~jason/address@hidden
=================== BUG #4953: FULL BUG SNAPSHOT ===================
Submitted by: jmccarty Project: GNU arch -- a revision control
system
Submitted on: Mon 08/25/03 at 21:20
Category: tla Severity: 5 - Major
Bug Group: bug Resolution: Works for me
Status: Feedback Release: tla--devo--1.1--patch-131
Fixed Release: Merge Request?: yes -- merge from my
archive
Your Archive Name: address@hidden Archive Location:
http://complex.dyndns.org:8000/~jason/address@hidden
Assigned to: None
Summary: minor bugs in cmd-archive-mirror
Original Submission: archive-mirror doesn't accept a lone limit argument,
contrary to what I would expect from the help output. Also, commands of the
form "tla archive-mirror archive-name limit-spec garbage-text" don't trigger an
error message.
I've fixed these by rewriting the archive and limit determination code in
cmd-archive-mirror.c. It should now match the behavior described by the help
output exactly. I believe that my changes should make future enhancement of the
limit argument easier as well (being more straight-forward than the original
code). My changes are in tla--devo--1.1--patch-6 in the listed archive.
In the process, I also discovered that the arch_archive_mirror function doesn't
print a warning if the specified limit doesn't exist in the source archive. Is
this a bug?
Please note that I will be unable to send or receive email for an indeterminate
period of time, maybe a day or two (hurray for the sysadmin!).
Follow-up Comments
*******************
-------------------------------------------------------
Date: Sun 11/09/03 at 01:04 By: jmccarty
I updated my branch of tla after all this time, since I'm still seeing this
apparent bug:
$ tla push-mirror tla--devo
/tmp/dists--devo--1.0--patch-49/src/tla/libarch/archives.c:36:botched invariant
arch_valid_archive_name (archive_name)
PANIC: exiting on botched invariant
My branch allows you to pass just the limit while treating the default archive
as MINE, which IMO is useful and matches the description more accurately.
The revision is at address@hidden/tla--devo--1.1--patch-9
http://complex.dyndns.org:8000/~jason/address@hidden
-------------------------------------------------------
Date: Sat 08/30/03 at 07:29 By: jmccarty
> cmd-archive-mirror.c has changed recently --
> could you please update your patch against the
> latest sources?
Done. It just had some trivial error message changes, so I'm still seeing the
bug (testing with patch-146).
$ tla my-default-archive address@hidden
$ tla push-mirror dists--devo--1.0
/tmp/dists--devo--1.0--patch-44/src/tla/libarch/archives.c:36:botched invariant
arch_valid_archive_name (archive_name)
PANIC: exiting on botched invariant
Whereas this works fine:
$ tla push-mirror address@hidden dists--devo--1.0
The current code assumes that the first argument, if any, is an archive name,
which isn't the meaning I get from the help text.
-------------------------------------------------------
Date: Sat 08/30/03 at 04:23 By: tomlord
I take that back -- actually I can't reproduce the
bug: a single argument to push-mirror works fine for
me. Will you please verify that the bug is still present
and, if not, close the bug?
-------------------------------------------------------
Date: Sat 08/30/03 at 04:20 By: tomlord
cmd-archive-mirror.c has changed recently --
could you please update your patch against the
latest sources?
> I also discovered that the arch_archive_mirror function
> doesn't print a warning if the specified limit doesn't
> exist in the source archive. Is this a bug?
Arguably, sure.
-t
-------------------------------------------------------
Date: Fri 08/29/03 at 21:34 By: jmccarty
I realized that this bug applies to tla 1.0 as well, so you might consider
applying my patch there too. Even though it changes the syntax accepted by
archive-mirror, it only changes it to match the syntax specified by -H.
Also, my email is working fine now.
CC list is empty
No files currently attached
For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4953&group_id=4899
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Bug-gnu-arch] [bug #4953] minor bugs in cmd-archive-mirror,
nobody <=