[Bug-gnu-arch] [bug #5948] using regex for validating input

[nobody]

=================== BUG #5948: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5948&group_id=4899

Changes by: Robert Collins <address@hidden>
Date: Mon 11/17/2003 at 06:06 (GMT)

------------------ Additional Follow-up Comments ----------------------------
I think that heading towards space support for filenames is a good thing. I'm 
not sure that using regexs for parsing is the best solution for that.



=================== BUG #5948: FULL BUG SNAPSHOT ===================


Submitted by: cehteh                  Project: GNU arch -- a revision control 
system
Submitted on: Tue 10/14/2003 at 14:08
Category:  tla                        Severity:  5 - Major                  
Bug Group:  large feature idea        Resolution:  None                     
Status:  Open                         Release:                              
Fixed Release:  tla--devo--1.1--patch-5Merge Request?:  yes -- merge from my 
archive
Your Archive Name:  address@hidden Archive Location:  
http://cehteh.homeunix.org/arch/cehteh000
Assigned to:  None                    

Summary:  using regex for validating input

Original Submission:  Regex for parsing the multitree config file



pros and cons:

 + better validation of input

 + more precise error reports

 + filenames can be quoted now and might contain spaces then  

 - much slower (probably one can optimize the regex to gain speed)



further ideas:

 * envvar expansion

 * escaping rules for spaces and special chars in strings



Please review the idea and think about applying it on serveral areas in tla (i 
plan to add support for filenames with spaces throughout tla with this)



the structured_regex.h file should live somewhere else, maybe in hackerlab, but 
its still quite immature.



In all this works so far but its only a proof of concept and need to be judged 
if we want to use it.



2003-10-14 12:18:45 GMT Christian Thaeter <address@hidden>        patch-5



    Summary:

      new regex parser for configs

    Revision:

      tla--devo--1.1--patch-5



    new regex parser for configs

    



    new files:

     libarch/arch_regex.h libarch/structured_regex.h



    modified files:

     libarch/configs.c









Christian

Follow-up Comments
*******************

-------------------------------------------------------
Date: Mon 11/17/2003 at 06:06       By: robertc
I think that heading towards space support for filenames is a good thing. I'm 
not sure that using regexs for parsing is the best solution for that.


CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5948&group_id=4899

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/