[Bug-gnu-arch] [bug #5690] Add a precommit hook

[nobody]

=================== BUG #5690: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5690&group_id=4899

Changes by: Robert Collins <address@hidden>
Date: Tue 11/25/2003 at 21:36 (GMT)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
merged into address@hidden/tla--devo--1.1--patch-201



=================== BUG #5690: FULL BUG SNAPSHOT ===================


Submitted by: mega-nerd               Project: GNU arch -- a revision control 
system
Submitted on: Thu 10/02/2003 at 10:55
Category:  tla                        Severity:  5 - Major                  
Bug Group:  small feature idea        Resolution:  Fixed                    
Status:  Closed                       Release:  tla-1.1pre5                 
Fixed Release:                        Merge Request?:  None                 
Your Archive Name:                    Your Archive Location:                
Assigned to:  None                    

Summary:  Add a precommit hook

Original Submission:  There is currently a hook in the commit function which 
runs

at the end of the commit process. It would also be useful 

to have a hook run at the start of the commit process and 

be able to abort the commit process by returning a non-zero

error code from the hook script.



An example of what can be done with this is to do a make in 

the the hook script and have the script return make's error

code. This means that a compile will be done during the 

commit hook and if the code doesn't build it won't commit

and broken code doesn't get into the archive.



Obviously if someone wants to bypass this process they can.

This is meant to prevent accidental commits of broken code.



I have included a diff which seems to work for me, but I'm

not totally sure that its correct. I have also mentioned 

the previous version of this patch on the mailing list.





Follow-up Comments
*******************

-------------------------------------------------------
Date: Tue 11/25/2003 at 21:36       By: robertc
merged into address@hidden/tla--devo--1.1--patch-201

-------------------------------------------------------
Date: Sat 11/08/2003 at 01:44       By: robertc
I've committed this into my archive as address@hidden/tla--devo--1.1--patch-22. 


CC List
*******

CC Address                          | Comment
------------------------------------+-----------------------------
robertc                             | 



File Attachments
****************

-------------------------------------------------------
Date: Thu 10/02/2003 at 10:55  Name: tla-1.1pre5-precommit.diff  Size: 1KB   
By: mega-nerd
A patch that seems to work.
http://savannah.gnu.org/bugs/download.php?group_id=4899&amp;bug_id=5690&amp;bug_file_id=697


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5690&group_id=4899

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/