[Bug-gnu-arch] [bugs #5635] library-file fails to find implicit (names) files in tagline method

[Robert Collins]

This mail is an automated notification from the bugs tracker
 of the project: GNU arch -- a revision control system.

/**************************************************************************/
[bugs #5635] Latest Modifications:

Changes by: 
                Robert Collins <address@hidden>
'Date: 
                Mon 12/01/2003 at 20:52 (GMT)

            What     | Removed                   | Added
---------------------------------------------------------------------------
       Fixed Release |                           | 
address@hidden/tla--devo--1.1--patch-237


------------------ Additional Follow-up Comments ----------------------------
Tom has not merged the patch for this - the root cause fix for the related 5554 
bug, conflicted. Can you see if this bug still occurs with Tom's latest code 
(address@hidden/tla--devo--1.1--patch-237) ? (We aren't sure - no test case was 
provided)






/**************************************************************************/
[bugs #5635] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=5635>
Project: GNU arch -- a revision control system
Submitted by: Bruce Stephens
On: Tue 09/30/2003 at 11:00

Category:  tla
Severity:  5 - Average
Item Group:  bug
Resolution:  None
Status:  Open
Release:  head tla--devo--1.1--patch-187
Fixed Release:  address@hidden/tla--devo--1.1--patch-237
Merge Request?:  None
Your Archive Name:  
Your Archive Location:  
Assigned to:  None


Summary:  library-file fails to find implicit (names) files in tagline method

Original Submission:  This is presumably related to #5554.  In a working tree 
using

tagline method, files which are explicitly added or have a

tagline can be found in a library, but files which just have

the right name (foo.c, say) and are in fact in the revision

library aren't found (I get the message "file not found in

the library").

Follow-up Comments
------------------


-------------------------------------------------------
Date: Mon 12/01/2003 at 20:52       By: robertc
Tom has not merged the patch for this - the root cause fix for the related 5554 
bug, conflicted. Can you see if this bug still occurs with Tom's latest code 
(address@hidden/tla--devo--1.1--patch-237) ? (We aren't sure - no test case was 
provided)

-------------------------------------------------------
Date: Tue 11/25/2003 at 13:32       By: robertc
address@hidden/tla--integration--1.1--patch-29 contains this, ready IMO for Tom.

-------------------------------------------------------
Date: Wed 11/12/2003 at 04:53       By: gnubert
This should be fixed the same way as in #5554. Related to this, "library-file 
--this" didn't seem to work for untagged source files, when called in a 
different directory than the tree root. "larch library-file --help" suggests:



  "--this find the tag of FILE relative to the current directory, then find the 
corresponding file in the library"



This is similar to how file-diffs and file-find behave, but library-file 
currently does not (for untagged files). It would have to derive the project 
root from the specified file, and get a path of the file relative to that root. 
Otherwise arch_inventory_id will give the wrong id. I tried to fix this in the 
patches below. A function arch_tree_file_relpath has been added to 
project-tree.c (patch-26), that does the steps described above, and gets used 
by all three files, cmd-file-diffs.c, cmd-file-find.c, and cmd-library-file.c 
(patch-27, for the first two functions this reduces some code).



Archive Location:

  http://wmipf.in-berlin.de/{archives}/devel-2003



address@hidden/tla--wmipf--1.1--patch-24

    merge with lord

address@hidden/tla--wmipf--1.1--patch-25

    fix library-file and file-{find,diffs} for untagged files

address@hidden/tla--wmipf--1.1--patch-26

    add function arch_tree_file_relpath

address@hidden/tla--wmipf--1.1--patch-27

    use arch_tree_file_relpath














For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=5635>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/