Re: Corrected: Gud.el Update - Improved Java Debugging Support for Emacs version 21

[Andreas Schwab]

"Zoltan Kemenczy" <kemenczy@home.com> writes:

|> --- 1505,1558 ----
|>   ;; ======================================================================
|>   ;; gud jdb variables and functions
|> 
|> ! (defcustom gud-jdb-command-name "jdb"
|> !   "Command that executes the Java debugger."
|> !   :type 'string
|> !   :group 'gud)
|> !
|> ! (defcustom gud-jdb-use-classpath t
|> !   "If t, search for Java source files in classpath directories.

Please write "If non-nil, ...".

|> ! (defvar gud-jdb-classpath nil
|> !  "Java/jdb classpath directories list.
|> ! If `gud-jdb-use-classpath' is t, gud-jdb derives the`gud-jdb-classpath'

Same here.  Also, as space is missing after "the".

|> ***************
|> *** 2482,2487 ****
|> --- 2652,2684 ----
|>      ((= span-end ?[) t)
|>      (t nil)))
|>        (t nil))))
|> +
|> + (defun gud-find-class (f)
|> +   "Find fully qualified class corresponding to file f.

Please use a more descriptive name instead of `f'.  I'd suggest using
`filename', and then writing "Find fully qualified class corresponding to
file FILENAME." in the doc string (ie., refer to parameters in upper
case).

Andreas.

-- 
Andreas Schwab                                  "And now for something
Andreas.Schwab@suse.de                          completely different."
SuSE Labs, SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5