Re: Emacs 21.2 core dump in find_first_unchanged_at_end_row

[Gerd Moellmann]

Paul Eggert <eggert@twinsun.com> writes:

> > From: gerd.moellmann@t-online.de (Gerd Moellmann)
> > Date: 29 Mar 2002 23:56:53 +0100
> > 
> > Did you compile Emacs with -DGLYPH_DEBUG?
> 
> Sorry, no.  It was a fairly vanilla build.

Then I think there's no way of proving that direct_output_for_insert
ran.

I have a strong gut feeling though it did get called, and that not
setting END_UNCHANGED in direct_output_for_insert has something to do
with the bogus unchanged info.  Alas, I don't see a way to prove that,
so I can only trust my gut.

What I've done is call mark_window_display_accurate in
direct_output_for_insert.  That should be done anyway, and removes any
doubt that direct_output_for_insert DTRT with unchanged info in the
future.  A patch is at the end of this mail.

I've installed this in HEAD.  Could someone please tell me if the RC
branch is still in use?  If so, I think this should be installed in the
branch, too.

*** dispnew.c   2002/03/30 11:50:25     1.302
--- dispnew.c   2002/03/30 11:51:51
***************
*** 3655,3668 ****
    fflush (stdout);
  
    TRACE ((stderr, "direct output for insert\n"));
! 
!   UNCHANGED_MODIFIED = MODIFF;
!   BEG_UNCHANGED = GPT - BEG;
!   XSETFASTINT (w->last_point, PT);
!   w->last_cursor = w->cursor;
!   XSETFASTINT (w->last_modified, MODIFF);
!   XSETFASTINT (w->last_overlay_modified, OVERLAY_MODIFF);
! 
    redisplay_performed_directly_p = 1;
    return 1;
  }
--- 3655,3661 ----
    fflush (stdout);
  
    TRACE ((stderr, "direct output for insert\n"));
!   mark_window_display_accurate (it.window, 1);
    redisplay_performed_directly_p = 1;
    return 1;
  }