[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
browse-url.el actually hardwires names
From: |
Dan Jacobson |
Subject: |
browse-url.el actually hardwires names |
Date: |
Tue, 13 Apr 2004 01:17:58 +0800 |
Gentlemen, in browse-url.el we see passages like
(message "Starting Netscape...")
(apply 'start-process (concat "netscape" url) nil
browse-url-netscape-program
He has hardwired the word Netscape into the message, whilst allowing
the variable browse-url-netscape-program to vary.
Therefor he would be better off saying
(message "Starting browse-url-netscape-program") or better
(message (concat "Starting " browse-url-netscape-program))
The user would then not still see "Netscape" when he has instead
left it for some future rival.
There are several similar occurrences of this throughout the file.
$ grep Starting /usr/share/emacs/21.3/lisp/net/browse-url.el
(message "Starting Netscape...")
(message "Starting Mozilla...")
(message "Starting Galeon...")
(message "Starting Mosaic...")
(message "Starting Mosaic...done"))))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- browse-url.el actually hardwires names,
Dan Jacobson <=