Re: backup-buffer-copy loops if old backup can't be deleted

[Ulrich Mueller]

>>>>> On Thu, 23 Aug 2007, Richard Stallman wrote:

> I think that fix is actually correct.

> So this change should be installed.

It has been installed, but ...

> I think there is no need to explicitly check whether the directory
> is writable.  What would be the purpose of that?

... the previous change was not completely reverted, variable "dir"
still gets assigned but is not used.

So the following patch should be applied in addition:

--- files.el    24 Aug 2007 03:03:52 -0000      1.922
+++ files.el    13 Aug 2007 13:40:58 -0000      1.919
@@ -3172,9 +3172,7 @@
            (file-error nil))))))
 
 (defun backup-buffer-copy (from-name to-name modes)
-  (let ((umask (default-file-modes))
-       (dir (or (file-name-directory to-name)
-                default-directory)))
+  (let ((umask (default-file-modes)))
     (unwind-protect
        (progn
          ;; Create temp files with strict access rights.  It's easy to