bug#4992: marked as done (Invalid use of strcpy() in etags)

[Emacs bug Tracking System]

Your message dated Mon, 23 Nov 2009 10:51:42 +0100
with message-id <4B0A5B2E.8050305@swipnet.se>
and subject line Re: bug#4992: Invalid use of strcpy() in etags
has caused the Emacs bug report #4992,
regarding Invalid use of strcpy() in etags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4992: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4992
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

--- Begin Message --- Subject: Invalid use of strcpy() in etags Date: Fri, 20 Nov 2009 16:43:05 +0100 User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4 The function absolute_filename() lib-src/etags.c has two invalid calls to strcpy() with overlapping arguments. It's undefined C that often happens to work, but breaks very badly for at least gcc 4.4.2 and glibc 2.11 on x86_64, which is default for Fedora 12.

The attached patch replaces the bogus strcpy() calls with calls to memmove().

/Tobias

emacs-23.1-strcpy-bug.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#4992: Invalid use of strcpy() in etags
>
>
>
>
> Date: 
>
> Mon, 23 Nov 2009 10:51:42 +0100
>
>
>
>
> User-agent: 
>
> Thunderbird 2.0.0.23 (X11/20090817)
>
>
>
>
> Tobias Ringström skrev:
> > The function absolute_filename() lib-src/etags.c has two invalid calls 
> > to strcpy() with overlapping arguments. It's undefined C that often 
> > happens to work, but breaks very badly for at least gcc 4.4.2 and glibc 
> > 2.11 on x86_64, which is default for Fedora 12.
> >
> > The attached patch replaces the bogus strcpy() calls with calls to 
> > memmove().
>
> Checked in, thanks.
>
>         Jan D.
>
> --- End Message ---