[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#5364: 23.1.91; execute-extended-command should do like FFAP
From: |
Juri Linkov |
Subject: |
bug#5364: 23.1.91; execute-extended-command should do like FFAP |
Date: |
Thu, 14 Jan 2010 23:07:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (x86_64-pc-linux-gnu) |
> Single examples of "text at point" don't help me understand why this
> happens *repeatedly*. If you could describe where those chunks of text
> come from and why you end up using them in M-x, maybe that would help.
After this bug report, I started to notice that most often I want to
put a command name at point to the M-x minibuffer is when I'm looking
at a new package and trying out its commands.
> It's bad to have a default in the prompt which is almost always not the
> one you want. People will soon send bug reports about "M-x chooses dumb
> defaults".
I agree that a default should not be in the prompt of M-x.
> In the pretest code, we've solved this problem by making M-n bring up
> the "file at point" if you have ffap loaded (IIUC). This should work
> with all file-reading commands, contrary to FFAP itself which only
> works for the commands it redefined.
> So after C-x i, try M-n.
We could do the same for M-x to let M-n to bring up the command at point.
This single default value will replace the current list of useless
default values reported in bug#5214.
The following patch closes both bug#5364 and bug#5214. For bug#5364
it adds the command at point when typing `M-x M-n' (but not to the
prompt of M-x). For bug#5214 it removes a list of confusing random
values for `M-x M-n M-n'.
I know that relying on the `minibuffer-history-variable' being equal
to `extended-command-history' is not a clean solution, but it works,
and currently I see no other way to achieve the same result.
=== modified file 'lisp/simple.el'
--- lisp/simple.el 2010-01-13 08:35:10 +0000
+++ lisp/simple.el 2010-01-14 21:07:12 +0000
@@ -1375,9 +1375,13 @@ (defun minibuffer-default-add-completion
(all (all-completions ""
minibuffer-completion-table
minibuffer-completion-predicate)))
- (if (listp def)
- (append def all)
- (cons def (delete def all)))))
+ (if (eq minibuffer-history-variable 'extended-command-history)
+ (with-current-buffer (window-buffer (minibuffer-selected-window))
+ (and (function-called-at-point)
+ (format "%S" (function-called-at-point))))
+ (if (listp def)
+ (append def all)
+ (cons def (delete def all))))))
(defun goto-history-element (nabs)
"Puts element of the minibuffer history in the minibuffer.
--
Juri Linkov
http://www.jurta.org/emacs/
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, jidanni, 2010/01/12
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, Juri Linkov, 2010/01/12
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, jidanni, 2010/01/12
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, Stefan Monnier, 2010/01/12
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, jidanni, 2010/01/12
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, Stefan Monnier, 2010/01/12
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, jidanni, 2010/01/13
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, Stefan Monnier, 2010/01/14
- bug#5364: 23.1.91; execute-extended-command should do like FFAP,
Juri Linkov <=
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, Stefan Monnier, 2010/01/14
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, Juri Linkov, 2010/01/14
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, Stefan Monnier, 2010/01/14
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, Chong Yidong, 2010/01/14
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, Stefan Monnier, 2010/01/15
- bug#5364: 23.1.91; execute-extended-command should do like FFAP, Juri Linkov, 2010/01/15
bug#5364: 23.1.91; execute-extended-command should do like FFAP, Jan D., 2010/01/13
bug#5364: 23.1.91; execute-extended-command should do like FFAP, jidanni, 2010/01/14