[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#5513: Archives disregard special mode-class
From: |
Juri Linkov |
Subject: |
bug#5513: Archives disregard special mode-class |
Date: |
Thu, 04 Feb 2010 21:52:29 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) |
>> I think all `view-buffer' calls should respect the property `mode-class',
>> so I moved this code from `view-file' to `view-buffer'. `view-buffer-1'
>> is a new function with the old content of `view-buffer' for the case when
>> some package would prefer to ignore `mode-class' for some reasons.
>
>> I hesitate to install this patch now because it changes the behavior of
>> `view-file' for a non-critical bug.
>
> Indeed, in this form I don't think it's acceptable for `trunk'.
> If you switch the names around, OTOH it should be safe.
I think in the long run the correct behavior of `view-buffer' should be to
check `mode-class'. Instead of switching the behavior after the release,
we could wait and install the final version of `view-buffer' (that checks for
`mode-class') after feature freeze (or install now to the `pending' branch).
--
Juri Linkov
http://www.jurta.org/emacs/