bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#5591: 23.1.92; bookmark.el and file path


From: Stefan Monnier
Subject: bug#5591: 23.1.92; bookmark.el and file path
Date: Thu, 18 Feb 2010 09:00:45 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (gnu/linux)

> is there any reason to expand-file-name here in bookmark-relocate?

> ,----
> | (let* ((bmrk-filename (bookmark-get-filename bookmark))
> |        (newloc (expand-file-name ==> here
> |                 (read-file-name
> |                  (format "Relocate %s to: " bookmark)
> |                  (file-name-directory bmrk-filename)))))
> `----

> Work fine without here.

read-file-name can return a relative file name, so yes, expand-file-name
is needed.  So the solution is to add a call to abbreviate-file-name.


        Stefan








reply via email to

[Prev in Thread] Current Thread [Next in Thread]