bug#7548: 23.2.90; bookmark-default-handler wrong documentation

[Leo]

On 2010-12-04 05:45 +0000, Leo wrote:
> As far as I can tell the arg BMK-RECORD to bookmark-default-handler is
> not a bookmark record but a BOOKMARK. This is probably leftover. Could
> someone correct this? Thanks.
>
> Leo

Posted on Theirry's behalf.

================================
Leo <sdl.web@gmail.com> writes:

> Hello Thierry,
>
> I am wondering if you have time to comment on
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7548.

Yes indeed, in bookmark-default-handler but also on other places in
bookmark.el, the argument "bookmark" is confusing.
It refer sometime to a "bookmark-name" and sometimes to a
"bookmark-record".
That is a vestige of old version of `bookmark-prop-get' that was
accepting only "bookmark-record".
But now `bookmark-prop-get' accept both, so such comments in docstring
are no more needed.
Also the arg "bookmark" should be "bookmark-name" or "bookmark-record"
instead of "bookmark".
All functions bookmark-get-* are calling `bookmark-prop-get'.

,----[ Exemple ]
| (bookmark-prop-get '("Any comment on bug #7548 "
|                      (visits . 0)
|                      (time . 1291556487.101218)
|                      (position . 219)
|                      (location . "Gnus-art 
nnimap+gmail:INBOX:12912:<m1vd389yjo.fsf@cam.ac.uk>")
|                      (group . "nnimap+gmail:INBOX")
|                      (article . 12912)
|                      (message-id . "<m1vd389yjo.fsf@cam.ac.uk>")
|                      (handler . gnus-summary-bookmark-jump))
|                    'handler)
| ==>gnus-summary-bookmark-jump
| 
| (bookmark-prop-get "Any comment on bug #7548 " 'handler)
| ==>gnus-summary-bookmark-jump
`----

Maybe you can forward this to emacs-bug?

> Thanks.
>
> Leo

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 
================================