[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7585: 23.2.90; [PATCH] fix eshell-previous-matching-input
From: |
Stefan Monnier |
Subject: |
bug#7585: 23.2.90; [PATCH] fix eshell-previous-matching-input |
Date: |
Mon, 13 Dec 2010 12:00:19 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
> There is a customisable variable eshell-hist-move-to-end when set to
> nil, point is not guaranteed to be located behind
> eshell-last-output-end. Thus blindly calling delete-region and
> insert-and-inherit will generate an error in that case.
The patch looks good as well, tho we usually prefer not to use `assert'
in this way (I'd keep assert for actual coding errors, so better use an
if test that then `signal's an error).
Stefan