[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7856: bug#7859: syncing Emacs from sources maintained elsewhere
From: |
Paul Eggert |
Subject: |
bug#7856: bug#7859: syncing Emacs from sources maintained elsewhere |
Date: |
Wed, 19 Jan 2011 15:44:40 -0800 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 |
I see that Jan Djärv tracked the problem down:
unexmacosx.c included <unistd.h> before <config.h>,
and this caused the problem. Generally speaking, <config.h>
should be included before all other files, since it
defines macros such as _FILE_OFFSET_BITS that may affect
the ABI, and compiling files sometimes with one ABI and
sometimes with another can lead to disaster.
I see that unexmacos.c still doesn't include <config.h> first,
though. I suggest that it be changed to do that.
A quick scan for other files with the problem show that
the following files probably need the "#include <config.h>"
moved to the top too:
w32.c
w32proc.c
- bug#7859: syncing Emacs from sources maintained elsewhere, Paul Eggert, 2011/01/19
- Message not available
- Message not available
- bug#7856: syncing Emacs from sources maintained elsewhere, Paul Eggert, 2011/01/19
- bug#7859: syncing Emacs from sources maintained elsewhere, Jan Djärv, 2011/01/19
- bug#7856: bug#7859: syncing Emacs from sources maintained elsewhere,
Paul Eggert <=
- bug#7859: syncing Emacs from sources maintained elsewhere, Eli Zaretskii, 2011/01/19
- bug#7859: syncing Emacs from sources maintained elsewhere, Jan Djärv, 2011/01/20
- bug#7856: bug#7859: syncing Emacs from sources maintained elsewhere, Paul Eggert, 2011/01/20
- bug#7859: syncing Emacs from sources maintained elsewhere, Jan D., 2011/01/20
- bug#7859: syncing Emacs from sources maintained elsewhere, Eric Blake, 2011/01/19