bug#8368: 24.0.50; "temp" means "help" - rename or at least document

[Lars Magne Ingebrigtsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Digging through the ChangeLogs, this is apparently the commit that
> added them, but it doesn't say why.
>
> 1999-01-11  Richard Stallman  <rms@psilocin.ai.mit.edu>
>
>       * help.el (help-mode-finish): Renamed from help-mode-maybe.
>       Don't switch to Help mode here.
>       (temp-buffer-setup-hook): Use help-mode-finish.
>       (help-mode-setup): New function.
>       (temp-buffer-setup-hook): Use help-mode-setup.
>
> Richard, why is `help-mode-setup' run in absolutely all
> `with-output-to-temp-buffer' buffers?  This seems rather un-optimal,
> since that macro is used for many other things than showing help
> buffers.

There's been no response in two months.

I think the following is a bug:

;; This makes `with-output-to-temp-buffer' buffers use `help-mode'.
(add-hook 'temp-buffer-setup-hook 'help-mode-setup)
(add-hook 'temp-buffer-show-hook 'help-mode-finish)

Would removing these be a good idea?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/