bug#9336: 24.0.50; No way to input character #xbb4 using ta-itrans

[Jambunathan K]

Kenichi

>> Above character has two bindings - "za" or "Ja".
>> We can go with "za".  
>
> Ah, I forgot about my patch.

Yes, there is a pending patch.

> Anyway, please try the attached patch for
> leim/quail/indian.el.  How is the result of C-h C-\
> tamil-itrans RET?  Is it ok now?

The new 2-D table looks pretty good and I am VERY HAPPY with the
changes.

I have made some changes - presentation-wise - on top of your changes. I
have attached 3 screenshots that demonstrates the changes that I have
made [1]. FYI, my FSF copyright assignment number for Emacs is #618390.

I also propose that some additional changes be made to quail.el [2]. I
am unsure how to introduce these changes cleanly.

indian.el.9336.patch
Description: Text Data

Footnotes: 
[1]  Summary of ta-itrans changes

ta-itrans-1.png
Description: PNG image

ta-itrans-2.png
Description: PNG image

ta-itrans-3.png
Description: PNG image

+ ta-itrans-1.png
  - I have introduced horizontal grid lines

  - I have added #0BB6 to the table. The character has no input method
    available. So the input row is left empty.

    Note: Furthermore, the associated glyphs are not available. (I have
    Tamil Lohit 2.4.5 - Thanks for suggesting this font!). So the tamil
    characters in that row looks malformed.

+ ta-itrans-2.png
  - I have split the single misc table used in your patch and split it
    in to two tables - "signs and digits table" and "numerics and
    symbols table".

    In the first table, 
    - I have removed Virama (0BCD) and Anusvara (0B82).
    - I have added TAMIL OM (0BD0) and the compound character `srii'.

    In the second table,
    - The characters have no input method. So I have included a
      description in native language to denote the purpose they serve. I
      believe there are advantages to including this table. For example,
      - It completes the catalogue and one can easily find out whether
        once font needs to be upgraded to display these (rarely used)
        characters.
      - Should there be a future request for assigning input methods to
        them, one need not work on it afresh.

[2] Additional hacks to quail.el

+ ta-itrans-3.png
  - Removed the old table (about which I had complaints). I don't know
    how to do this cleanly. Here is a quick hack I cooked up (marked
    with @@@)

,---- In quail.el (around line 2550 or so)
|       (let* ((decode-map (list 'decode-map))
|                (num (quail-build-decode-map (list (quail-map)) "" decode-map
|                                             ;; We used to use 512 here, but
|                                             ;; TeX has more than 1000 and
|                                             ;; it's good to see the list.
|                                             0 5120 done-list)))
|@@@@@    (when (and nil (> num 0)) 
|           (insert "
| KEY SEQUENCE
| ------------
| ")
|           (if (quail-show-layout)
|               (insert "You can also input more characters")
|             (insert "You can input characters"))
|           (insert " by the following key sequences:\n")
|           (quail-insert-decode-map decode-map)))
`----

  - Place the cursor at the BEGINNING of help buffer rather than the end
    of it. There are more interesting things at the beginning of the
    buffer than the end of the buffer.

,---- In quail.el (around line 2575)
|       ;; Resize the help window again, now that it has all its contents.
|       (save-selected-window
|@@@    (goto-char (point-min))
|       (select-window (get-buffer-window (current-buffer) t))
|       (run-hooks 'temp-buffer-show-hook))
`----