[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP
From: |
Stefan Monnier |
Subject: |
bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP |
Date: |
Sat, 26 Jan 2013 17:24:37 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
>> > You call file-attributes, which encodes the file name and passes it to
>> > 'lstat'. The implementation of 'lstat' in w32.c then looks at the
>> > last byte of the encoded file name to see if there's a slash or
>> > backslash there. Boom!
>> I see. So, does that meant that w32.c can't faithfully implement lstat
>> without doing the moral equivalent of re-decoding its argument?
> It can, if we limit such support to Windows codepage encodings. See
> the changes I made on the emacs-24 branch revisions 111194 and 111200.
CharNextExA and CharPrevExA, in my mind, do perform the moral equivalent
of decoding the argument (just in an incremental way).
> Personally, I think supporting all possible Windows codepages is
> good enough.
Fine by me,
Stefan
- bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP, Shigeru Fukaya, 2013/01/26
- bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP, Stefan Monnier, 2013/01/26
- bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP, Eli Zaretskii, 2013/01/26
- bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP, Stefan Monnier, 2013/01/26
- bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP, Eli Zaretskii, 2013/01/26
- bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP,
Stefan Monnier <=
- bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP, Eli Zaretskii, 2013/01/27
- bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP, Shigeru Fukaya, 2013/01/27
- bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP, Eli Zaretskii, 2013/01/27
bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP, Eli Zaretskii, 2013/01/26