bug#13402: 24.2.92 pretest: bugs in isearch-yank-line in info page. [Patch]

[Juri Linkov]

> It fails only in `replace-highlight', i.e. after running `query-replace'
> and answering `n' to skip to the next match, it doesn't re-highlight
> the previous skipped match.

Also I noticed that typing `C-s M-s SPC C-s' quickly causes the error:

Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
  overlays-in(nil 244)
  (if isearch-forward (overlays-in isearch-other-end (point)) (overlays-in 
(point) isearch-other-end))
  (let ((ovs (if isearch-forward (overlays-in isearch-other-end (point)) 
(overlays-in (point) isearch-other-end))) ov) (while ovs (setq ov (car ovs) ovs 
(cdr ovs)) (if (memq ov isearch-lazy-highlight-overlays) (progn (overlay-put ov 
(quote face) nil) (setq isearch-lazy-highlight-shadowed ov)))))
  isearch-lazy-highlight-move-shadow()
  (if (and (null executing-kbd-macro) (sit-for 0) (or (not (equal 
isearch-string isearch-lazy-highlight-last-string)) (not (eq (selected-window) 
isearch-lazy-highlight-window)) (not (eq 
isearch-lazy-highlight-case-fold-search isearch-case-fold-search)) (not (eq 
isearch-lazy-highlight-regexp isearch-regexp)) (not (eq 
isearch-lazy-highlight-word isearch-word)) (not (eq 
isearch-lazy-highlight-lax-whitespace isearch-lax-whitespace)) (not (eq 
isearch-lazy-highlight-regexp-lax-whitespace isearch-regexp-lax-whitespace)) 
(not (= (window-start) isearch-lazy-highlight-window-start)) (not (= 
(window-end) isearch-lazy-highlight-window-end)) (not (eq isearch-forward 
isearch-lazy-highlight-forward)) (not (equal isearch-error 
isearch-lazy-highlight-error)))) (progn (lazy-highlight-cleanup t) (setq 
isearch-lazy-highlight-error isearch-error) (setq 
isearch-lazy-highlight-start-limit beg isearch-lazy-highlight-end-limit end) 
(setq isearch-lazy-highlight-window (selected-window) 
isearch-lazy-highlight-window-start (window-start) 
isearch-lazy-highlight-window-end (window-end) isearch-lazy-highlight-start 
(point) isearch-lazy-highlight-end (point) isearch-lazy-highlight-point (point) 
isearch-lazy-highlight-shadowed nil isearch-lazy-highlight-wrapped nil 
isearch-lazy-highlight-last-string isearch-string 
isearch-lazy-highlight-case-fold-search isearch-case-fold-search 
isearch-lazy-highlight-regexp isearch-regexp 
isearch-lazy-highlight-lax-whitespace isearch-lax-whitespace 
isearch-lazy-highlight-regexp-lax-whitespace isearch-regexp-lax-whitespace 
isearch-lazy-highlight-word isearch-word isearch-lazy-highlight-forward 
isearch-forward) (if (equal isearch-string "") nil (setq 
isearch-lazy-highlight-timer (run-with-idle-timer lazy-highlight-initial-delay 
nil (quote isearch-lazy-highlight-update))))) 
(isearch-lazy-highlight-move-shadow))
  isearch-lazy-highlight-new-loop()
  isearch-update()
  isearch-toggle-lax-whitespace()
  call-interactively(isearch-toggle-lax-whitespace nil nil)


Oh, and another problem: after customizing `lazy-highlight-cleanup' to `nil',
exiting isearch doesn't leave the current match lazy-highlighted.

The problem is that other features are expecting that _all_ matches
are lazy-highlighted, so I'm starting to doubt whether it's worth the
trouble trying to improve such cosmetic issue?