[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#15260: cannot build in a directory with non-ascii characters
From: |
Stefan Monnier |
Subject: |
bug#15260: cannot build in a directory with non-ascii characters |
Date: |
Thu, 31 Oct 2013 15:24:57 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
> Below is what I came up with. This survived several bootstraps, both
Thanks, Eli.
> +;; Make sure default-directory is unibyte when dumping. This is
> +;; because we cannot decode and encode it correctly (since the locale
> +;; environment is not, and should not be, set up). default-directory
> +;; is used every time we call expand-file-name, which we do in every
> +;; file primitive. So the only workable solution to support building
> +;; in non-ASCII directories is to manipulate unibyte strings in the
> +;; current locale's encoding.
> +(if (and (or (equal (nth 3 command-line-args) "dump")
> + (equal (nth 4 command-line-args) "dump")
> + (equal (nth 3 command-line-args) "bootstrap")
> + (equal (nth 4 command-line-args) "bootstrap"))
> + (multibyte-string-p default-directory))
> + (setq default-directory (string-to-unibyte default-directory)))
I'm not sure I understand this string-to-unibyte.
This call seems to only be correct if default-directory holds the
undecoded but multibyte name.
Why would we have an undecided yet multibyte name?
IOW, I'd expect here to either have default-directory be unibyte
already, or be multibyte but encoded in some (arbitrary) encoding (in
which case we can't really know how to re-encode it).
Stefan
- bug#15260: cannot build in a directory with non-ascii characters, (continued)
- bug#15260: cannot build in a directory with non-ascii characters, Stefan Monnier, 2013/10/28
- bug#15260: cannot build in a directory with non-ascii characters, Eli Zaretskii, 2013/10/28
- bug#15260: cannot build in a directory with non-ascii characters, Stefan Monnier, 2013/10/29
- bug#15260: cannot build in a directory with non-ascii characters, Eli Zaretskii, 2013/10/30
- bug#15260: cannot build in a directory with non-ascii characters, Stefan Monnier, 2013/10/30
- bug#15260: cannot build in a directory with non-ascii characters, Eli Zaretskii, 2013/10/30
- bug#15260: cannot build in a directory with non-ascii characters, Stefan Monnier, 2013/10/31
- bug#15260: cannot build in a directory with non-ascii characters, Eli Zaretskii, 2013/10/31
- bug#15260: cannot build in a directory with non-ascii characters, Stefan Monnier, 2013/10/31
- bug#15260: cannot build in a directory with non-ascii characters, Eli Zaretskii, 2013/10/31
- bug#15260: cannot build in a directory with non-ascii characters,
Stefan Monnier <=
- bug#15260: cannot build in a directory with non-ascii characters, Eli Zaretskii, 2013/10/31
- bug#15260: cannot build in a directory with non-ascii characters, Eli Zaretskii, 2013/10/31
- bug#15260: cannot build in a directory with non-ascii characters, Stefan Monnier, 2013/10/31
- bug#15260: cannot build in a directory with non-ascii characters, Eli Zaretskii, 2013/10/31
- bug#15260: cannot build in a directory with non-ascii characters, Eli Zaretskii, 2013/10/31
- bug#15260: cannot build in a directory with non-ascii characters, Glenn Morris, 2013/10/31