[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#16804: 24.3.50; [PATCH] fix with-silent-modifications
From: |
Leo Liu |
Subject: |
bug#16804: 24.3.50; [PATCH] fix with-silent-modifications |
Date: |
Wed, 19 Feb 2014 14:10:45 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9.1) |
On 2014-02-19 12:39 +0800, Stefan Monnier wrote:
> I vaguely understand what kind of problem you're talking about, but not
> precisely enough to guess what kinds of fixes might make sense.
I think the problem is let-binding buffer-file-name and
buffer-file-truename to nil is a really bad idea. I did a grep on
buffer-file-name in lisp/ directory and got about 2000 entries. Code at
distance may run while eval'ing the body of with-silent-modifications
and affected by the nil value of buffer-file-name etc.
>> Any comments on the following fix? Thanks.
>
> I think I'd rather add a new inhibit-<something>, but it's hard to tell
> without knowing more of the problem at hand.
So with-silent-modifications needs another way to achieve its goal. From
reading its in-code comments, it seems it wants to prevent:
1. create and delete file locks.
2. change file modtime which could have effect beyond the scope
of the macro
Leo
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Leo Liu, 2014/02/18
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Stefan Monnier, 2014/02/18
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications,
Leo Liu <=
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Stefan Monnier, 2014/02/19
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Leo Liu, 2014/02/19
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Stefan Monnier, 2014/02/19
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Leo Liu, 2014/02/19
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Stefan Monnier, 2014/02/19
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Leo Liu, 2014/02/20
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Stefan Monnier, 2014/02/20
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Leo Liu, 2014/02/20
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Stefan Monnier, 2014/02/20
- bug#16804: 24.3.50; [PATCH] fix with-silent-modifications, Leo Liu, 2014/02/20