[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#17439: 24.3.50; run-with-idle-timer runs on focus-out
From: |
Juri Linkov |
Subject: |
bug#17439: 24.3.50; run-with-idle-timer runs on focus-out |
Date: |
Sat, 10 May 2014 23:38:20 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) |
> So are you saying we should NOT ignore focus-in? If you still think
> focus-in should be ignored, then I think the above description
> (perhaps together with the window manager where it was observed)
> should be in the comments to the code.
After more testing without ignoring focus-in and with ignoring focus-out,
often pressing and releasing Alt-Tab quickly generates both events
focus-in and focus-out, and when having no time to show the Window List
focus-in moves the mouse pointer and hides the selected window.
So both events should be ignored, like `switch-frame' is already ignored
when switching between Emacs frames. I'll add a comment about this.
And there are more fixes necessary in avoid.el. This patch will ignore
modifiers used together with mouse events:
=== modified file 'lisp/avoid.el'
--- lisp/avoid.el 2014-01-01 07:43:34 +0000
+++ lisp/avoid.el 2014-05-10 20:36:19 +0000
@@ -347,7 +348,13 @@ (defun mouse-avoidance-ignore-p ()
(memq 'double modifiers)
(memq 'triple modifiers)
(memq 'drag modifiers)
- (memq 'down modifiers)))))))
+ (memq 'down modifiers)
+ (memq 'meta modifiers)
+ (memq 'control modifiers)
+ (memq 'shift modifiers)
+ (memq 'hyper modifiers)
+ (memq 'super modifiers)
+ (memq 'alt modifiers)))))))
(defun mouse-avoidance-banish ()
(if (not (mouse-avoidance-ignore-p))
And this patch fixes the customization of `mouse-avoidance-banish-position'
(it can be tested by e.g. using `set-variable' on
`mouse-avoidance-banish-position'):
=== modified file 'lisp/avoid.el'
--- lisp/avoid.el 2014-01-01 07:43:34 +0000
+++ lisp/avoid.el 2014-05-10 20:36:19 +0000
@@ -129,9 +129,10 @@ (defcustom mouse-avoidance-banish-positi
TOP-OR-BOTTOM-POS: Distance from top or bottom edge of frame or window."
:group 'avoid
:version "24.3"
- :type '(alist :key-type symbol :value-type symbol)
- :options '(frame-or-window side (side-pos integer)
- top-or-bottom (top-or-bottom-pos integer)))
+ :type '(alist :key-type symbol :value-type (choice symbol integer))
+ :options '((frame-or-window symbol) (side symbol) (side-pos integer)
+ (top-or-bottom symbol) (top-or-bottom-pos integer)))
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Juri Linkov, 2014/05/08
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Eli Zaretskii, 2014/05/09
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Juri Linkov, 2014/05/09
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Eli Zaretskii, 2014/05/10
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out,
Juri Linkov <=
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Juri Linkov, 2014/05/11
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Stefan Monnier, 2014/05/11
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Juri Linkov, 2014/05/11
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Stefan Monnier, 2014/05/11
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Juri Linkov, 2014/05/12
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Stefan Monnier, 2014/05/13
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Juri Linkov, 2014/05/20
- bug#17439: 24.3.50; run-with-idle-timer runs on focus-out, Juri Linkov, 2014/05/20