bug#17849: 24.3; desktop-save-mode: can't load desktop saved while defining keyboard macro

[Keshav Kini]

Start Emacs with `emacs -Q` and enter the following:

    C-x f /tmp RET
    M-x desktop-save-mode RET
    M-x start-kbd-macro RET
    C-x C-c y RET

Emacs closes (as expected).  Start Emacs again with `emacs -Q` and enter
the following:

    M-: (desktop-read "/tmp")

The following backtrace is generated:

Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  defining-kbd-macro(1)
  desktop-create-buffer(206 nil "tmp" dired-mode (defining-kbd-macro) 206 (nil 
nil) t ("/tmp/") nil)
  eval-buffer(#<buffer  *load*> nil "/tmp/.emacs.desktop" nil t)  ; Reading at 
buffer position 753
  load-with-code-conversion("/tmp/.emacs.desktop" "/tmp/.emacs.desktop" t t)
  load("/tmp/.emacs.desktop" t t t)
  desktop-read("/tmp")
  eval((desktop-read "/tmp") nil)
  eval-expression((desktop-read "/tmp") nil)
  call-interactively(eval-expression nil nil)

Expected behavior is that the dired buffer for /tmp/ should be loaded.
Inspecting /tmp/.emacs.desktop shows that the `defining-kbd-macro'
minor mode is specified for every saved buffer (though in this minimal
example there is only one buffer in the file).  Removing this atom
from the list of minor modes for each buffer makes the desktop file
loadable once again.


In GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.12.2)
 of 2014-06-06 on barber, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11501000
System Description:     Debian GNU/Linux unstable (sid)

Configured using:
 `configure '--build' 'x86_64-linux-gnu' '--build' 'x86_64-linux-gnu'
 '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
 '--localstatedir=/var/lib' '--infodir=/usr/share/info'
 '--mandir=/usr/share/man' '--with-pop=yes'
 
'--enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.3/site-lisp:/usr/share/emacs/site-lisp'
 '--with-crt-dir=/usr/lib/x86_64-linux-gnu' '--with-x=yes'
 '--with-x-toolkit=gtk3' '--with-toolkit-scroll-bars'
 'build_alias=x86_64-linux-gnu' 'CFLAGS=-g -O2 -fstack-protector
 --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall'
 'LDFLAGS=-Wl,-z,relro' 'CPPFLAGS=-D_FORTIFY_SOURCE=2''

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: SML

Minor modes in effect:
  TeX-PDF-mode: t
  desktop-save-mode: t
  evil-leader-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  evil-mode: t
  evil-local-mode: t
  show-paren-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x r e p o r t - e m a c s - b u g <return>

Recent messages:
Starting: /usr/bin/coqtop -emacs-U
Enable proof tree display for Coq version 8.4pl3
policy = hybrid , pol = hybrid
M-x proof-prf for goals; M-x proof-layout-windows refreshes [2 times]
Starting coq process... done.
policy = hybrid , pol = hybrid
C-c C-p for goals; C-c C-l refreshes [2 times]
Wrote /home/fs/.emacs.d/.emacs.desktop.lock
Desktop: 80 buffers restored.
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
/usr/share/emacs24/site-lisp/proofgeneral/coq/coq hides 
/usr/share/emacs24/site-lisp/coq/coq
/usr/share/emacs24/site-lisp/proofgeneral/coq/coq-syntax hides 
/usr/share/emacs24/site-lisp/coq/coq-syntax
/usr/share/emacs24/site-lisp/proofgeneral/coq/coq-db hides 
/usr/share/emacs24/site-lisp/coq/coq-db
~/.emacs.d/custom/emacs-acl2 hides /usr/share/emacs24/site-lisp/acl2/emacs-acl2
~/.emacs.d/custom/monitor hides /usr/share/emacs24/site-lisp/acl2/monitor
/usr/share/emacs/24.3/site-lisp/debian-startup hides 
/usr/share/emacs/site-lisp/debian-startup
/usr/share/emacs24/site-lisp/cmake-data/cmake-mode hides 
/usr/share/emacs/site-lisp/cmake-mode
/usr/share/emacs24/site-lisp/dictionaries-common/ispell hides 
/usr/share/emacs/24.3/lisp/textmodes/ispell
/usr/share/emacs/site-lisp/rst hides /usr/share/emacs/24.3/lisp/textmodes/rst
/usr/share/emacs24/site-lisp/dictionaries-common/flyspell hides 
/usr/share/emacs/24.3/lisp/textmodes/flyspell
/home/fs/.emacs.d/elpa/fringe-helper-20130519.1641/.dir-locals hides 
/usr/share/emacs/24.3/lisp/gnus/.dir-locals

Features:
(shadow sort mail-extr emacsbug message rfc822 mml mml-sec mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils scheme
plain-tex caml cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs goto-addr thingatpt view
latexenc preview prv-emacs tex-buf font-latex latex tex-style tex dbus
xml which-func imenu coq coq-smie-lexer coq-indent coq-par-compile
coq-seq-compile coq-compile-common coq-abbrev coq-local-vars
local-vars-list coq-syntax coq-db holes proof proof-shell pg-user
pg-goals pg-response proof-toolbar pg-assoc proof-tree proof-script
proof-menu cus-edit wid-edit span proof-auxmodes proof-utils scomint
proof-syntax bufhist proof-splash pg-custom proof-config proof-faces
proof-useropts pg-pamacs proof-compat haskell-indent haskell-font-lock
haskell-mode haskell-string haskell-sort-imports haskell-align-imports
haskell-compat flymake dabbrev dired vc-git rst derived org-wl org-w3m
org-vm org-rmail org-mhe org-mew org-irc org-jsinfo org-infojs org-html
org-exp ob-exp org-exp-blocks org-agenda org-info org-gnus gnus-util
org-docview org-bibtex bibtex org-bbdb org byte-opt warnings bytecomp
byte-compile cconv ob-tangle ob-ref ob-lob ob-table org-footnote org-src
ob-comint ob-keys org-pcomplete pcomplete org-list org-faces
org-entities noutline outline easy-mmode org-version ob-emacs-lisp ob
org-compat org-macs ob-eval org-loaddefs format-spec find-func cal-menu
calendar cal-loaddefs nxml-uchnm rng-xsd xsd-regexp rng-cmpct rng-nxml
rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util
rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-glyph
nxml-enc xmltok sml-mode compile comint ansi-color electric smie desktop
cus-start cus-load server agda-input quail help-mode mozc evil-leader
evil evil-integration undo-tree diff evil-maps evil-commands evil-types
evil-search evil-ex evil-macros evil-repeat evil-states evil-core
evil-common windmove rect evil-digraphs evil-vars ring
adaptive-wrap-autoloads adoc-mode-autoloads auctex-autoloads tex-site
better-defaults-autoloads paren saveplace uniquify advice advice-preload
ido column-marker-autoloads ensime-autoloads auto-complete-autoloads
dash-autoloads evil-indent-textobject-autoloads evil-leader-autoloads
evil-nerd-commenter-autoloads evil-numbers-autoloads
evil-paredit-autoloads evil-autoloads flymake-haskell-multi-autoloads
flymake-rust-autoloads flymake-easy-autoloads
git-gutter-fringe-autoloads fringe-helper-autoloads git-gutter-autoloads
goto-chg-autoloads haskell-mode-autoloads edmacro kmacro
inf-ruby-autoloads linum-relative-autoloads magit-filenotify-autoloads
magit-find-file-autoloads magit-autoloads info easymenu
git-rebase-mode-autoloads git-commit-mode-autoloads
markup-faces-autoloads matlab-mode-autoloads minimap-autoloads
paredit-autoloads popup-autoloads qml-mode-autoloads rust-mode-autoloads
s-autoloads scala-mode2-autoloads sml-mode-autoloads
twittering-mode-autoloads undo-tree-autoloads
unicode-progress-reporter-autoloads ucs-utils-autoloads
persistent-soft-autoloads list-utils-autoloads help-fns pcache-autoloads
finder-inf package cl-macs gv proof-site proof-autoloads pg-vars
mmm-auto mmm-vars mmm-compat cl cl-lib agda2 time-date tooltip
ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
register page menu-bar rfn-eshadow timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer loaddefs button faces cus-face macroexp files text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty emacs)