bug#17912: inferior-octave-mode: Wrong type argument: number-or-marker-p, "100000000000"

[Stefan Monnier]

Version:24.4

>> Whenever I start octave-mode from emacs I got the following error message:
>> inferior-octave-mode: Wrong type argument: number-or-marker-p, "100000000000"

Apparently you're the only use who sets OCTAVE_HISTSIZE ;-)

I installed the patch below which should hopefully fix this problem,


        Stefan


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog      2014-07-03 23:48:24 +0000
+++ lisp/ChangeLog      2014-07-04 01:34:57 +0000
@@ -1,3 +1,8 @@
+2014-07-04  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+       * progmodes/octave.el (inferior-octave-mode):
+       Set comint-input-ring-size to a number (bug#17912).
+
 2014-07-03  Juri Linkov  <juri@jurta.org>
 
        * desktop.el (desktop-minor-mode-table): Add `defining-kbd-macro'

=== modified file 'lisp/progmodes/octave.el'
--- lisp/progmodes/octave.el    2014-04-12 04:07:53 +0000
+++ lisp/progmodes/octave.el    2014-07-04 01:34:11 +0000
@@ -747,9 +747,10 @@
   (setq-local info-lookup-mode 'octave-mode)
   (setq-local eldoc-documentation-function 'octave-eldoc-function)
 
-  (setq comint-input-ring-file-name
-        (or (getenv "OCTAVE_HISTFILE") "~/.octave_hist")
-        comint-input-ring-size (or (getenv "OCTAVE_HISTSIZE") 1024))
+  (setq-local comint-input-ring-file-name
+              (or (getenv "OCTAVE_HISTFILE") "~/.octave_hist"))
+  (setq-local comint-input-ring-size
+              (string-to-number (or (getenv "OCTAVE_HISTSIZE") "1024")))
   (comint-read-input-ring t)
   (setq-local comint-dynamic-complete-functions
               inferior-octave-dynamic-complete-functions)