[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#18048: 24.3.92; [patch] eldoc improvements
From: |
Thierry Volpiatto |
Subject: |
bug#18048: 24.3.92; [patch] eldoc improvements |
Date: |
Mon, 21 Jul 2014 09:24:50 +0200 |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Also the words &key and &allow-other-keys are upcased.
>
> Hmm... this eldoc code reminds me of similar code in help-fns.el.
> Can you take a look at it and see if we could consolidate them?
I didn't find in help-fns.el, but in help.el I found
`help-function-arglist' which is used by eldoc.
diff --git a/lisp/help.el b/lisp/help.el
index fa2a4f2..8bd5fd0 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -1294,7 +1294,7 @@ the same names as used in the original source code, when
possible."
(unless (and (symbolp arg)
(let ((name (symbol-name arg)))
(if (eq (aref name 0) ?&)
- (memq arg '(&rest &optional))
+ (memq arg '(&rest &optional &key
&allow-other-keys))
(not (string-match "\\." name)))))
(setq valid nil)))
(when valid arglist)))
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997