bug#18136: 24.4.50; crash in redisplay when calling load-theme

[martin rudalics]

>> I think so, especially because that's how they behaved before.
>
> If so, we agree, and this means the menu bar should be part of the TTY
> frame's dimensions.

Just that for a GUI frame the menubar is never counted in the text
height.

> No, we resize the frame and then redistribute the frame dimensions
> between its windows.  When change_frame_size_1 is called with the same
> dimensions as the current frame's dimensions, it simply does nothing
> and returns.

change_frame_size_1 _always_ calls adjust_frame_size now.  And the later
does (almost) nothing only if the following condition holds:

  if (new_text_width == old_text_width
      && new_text_height == old_text_height
      && new_windows_width == old_windows_width
      && new_windows_height == old_windows_height
      && new_pixel_width == old_pixel_width
      && new_pixel_height == old_pixel_height)
    /* No change.  Sanitize window sizes and return.  */

martin