[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#18399: 24.4.50; nadvice :filter-args -vs- interactive
From: |
Stefan Monnier |
Subject: |
bug#18399: 24.4.50; nadvice :filter-args -vs- interactive |
Date: |
Wed, 03 Sep 2014 22:59:14 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
Michael> According to the doc (of `add-function'), an filter-args advice
Michael> function has to accept exactly one argument (which is bound to
Michael> the list of given arguments). So I think what you see is
Michael> expected.
Michael> I have stumbled over that behavior several times myself.
> I looked at the docs again and I agree. Sorry about the noise. Perhaps
> a note and/or a small example here would be nice for future users. If
> we were both fooled by this then perhaps others will be as well.
FWIW, the use of a single formal arg receiving the actual arg-list
in :filter-args is based on performance reasons (we have the list
anyway, so it's more efficient to pass it to `funcall' than to `apply').
Stefan
- bug#18399: 24.4.50; nadvice :filter-args -vs- interactive, Tom Tromey, 2014/09/03
- bug#18399: 24.4.50; nadvice :filter-args -vs- interactive, Michael Heerdegen, 2014/09/03
- bug#18399: 24.4.50; nadvice :filter-args -vs- interactive, Tom Tromey, 2014/09/03
- bug#18399: 24.4.50; nadvice :filter-args -vs- interactive, Stefan Monnier, 2014/09/04
- bug#18399: 24.4.50; nadvice :filter-args -vs- interactive, Michael Heerdegen, 2014/09/04
- bug#18399: 24.4.50; nadvice :filter-args -vs- interactive, Stefan Monnier, 2014/09/04
- bug#18399: 24.4.50; nadvice :filter-args -vs- interactive, Michael Heerdegen, 2014/09/05
- bug#18399: 24.4.50; nadvice :filter-args -vs- interactive, Tom Tromey, 2014/09/06