bug#18332: 24.3.93; Convenience is a malformed function when installing ELPA package

[Fabrice Niessen]

Stefan Monnier wrote:
>> I only do have an error when launching a Cygwin Emacs...
>
> Can you try the patch I installed and see if it helps?

I (manually) patched the package.el file and removed the package.elc one.

Now, when I launch Emacs 24.3.93.1, I have this:

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (file-error "Cannot open load file" "no such file 
or directory" "tex-site")
  require(tex-site)
  eval-buffer(#<buffer  *load*-112579> nil 
"d:/Users/fni/.emacs.d/elpa/auctex-11.87.7/auctex-autoloads.el" nil t)  ; 
Reading at buffer position 9714
  
load-with-code-conversion("d:/Users/fni/.emacs.d/elpa/auctex-11.87.7/auctex-autoloads.el"
 "d:/Users/fni/.emacs.d/elpa/auctex-11.87.7/auctex-autoloads.el" nil t)
  load("d:/Users/fni/.emacs.d/elpa/auctex-11.87.7/auctex-autoloads" nil t)
  (condition-case err (load (expand-file-name (format "%s-autoloads" name) 
pkg-dir) nil t) ((debug error) (message "Error: %S" err) nil))
  (let ((old-lp load-path)) (condition-case err (load (expand-file-name (format 
"%s-autoloads" name) pkg-dir) nil t) ((debug error) (message "Error: %S" err) 
nil)) (if (and (eq old-lp load-path) (not (or (member pkg-dir load-path) 
(member pkg-dir-dir load-path)))) (progn (setq load-path (cons pkg-dir 
load-path)))))
  (let* ((name (progn (or (and (vectorp pkg-desc) (>= (length pkg-desc) 10) 
(memq (aref pkg-desc 0) cl-struct-package-desc-tags)) (error "%s accessing a 
non-%s" (quote package-desc-name) (quote package-desc))) (aref pkg-desc 1))) 
(pkg-dir (progn (or (and (vectorp pkg-desc) (>= (length pkg-desc) 10) (memq 
(aref pkg-desc 0) cl-struct-package-desc-tags)) (error "%s accessing a non-%s" 
(quote package-desc-dir) (quote package-desc))) (aref pkg-desc 7))) 
(pkg-dir-dir (file-name-as-directory pkg-dir))) (if pkg-dir nil (error 
"Internal error: unable to find directory for `%s'" (package-desc-full-name 
pkg-desc))) (let ((old-lp load-path)) (condition-case err (load 
(expand-file-name (format "%s-autoloads" name) pkg-dir) nil t) ((debug error) 
(message "Error: %S" err) nil)) (if (and (eq old-lp load-path) (not (or (member 
pkg-dir load-path) (member pkg-dir-dir load-path)))) (progn (setq load-path 
(cons pkg-dir load-path))))) (if (file-exists-p (expand-file-name "dir" 
pkg-dir)) (progn (require (quote info)) (info-initialize) (setq 
Info-directory-list (cons pkg-dir Info-directory-list)))) (setq 
package-activated-list (cons name package-activated-list)) t)
  package-activate-1([cl-struct-package-desc auctex (11 87 7) "Integrated 
environment for *TeX*" nil nil nil "d:/Users/fni/.emacs.d/elpa/auctex-11.87.7" 
((:url . "http://www.gnu.org/software/auctex/";)) nil])
  (if fail (warn "Unable to activate package `%s'.\nRequired package `%s-%s' is 
unavailable" package (car fail) (package-version-join (cadr fail))) 
(package-activate-1 pkg-vec))
  (let* ((pkg-vec (car pkg-descs)) (fail (catch (quote dep-failure) (let 
((--dolist-tail-- (progn ... ...))) (while --dolist-tail-- (let (...) (if ... 
nil ...) (setq --dolist-tail-- ...))))))) (if fail (warn "Unable to activate 
package `%s'.\nRequired package `%s-%s' is unavailable" package (car fail) 
(package-version-join (cadr fail))) (package-activate-1 pkg-vec)))
  (cond ((null pkg-descs) (package-built-in-p package)) ((and (memq package 
package-activated-list) (not force)) t) (t (let* ((pkg-vec (car pkg-descs)) 
(fail (catch (quote dep-failure) (let (...) (while --dolist-tail-- ...))))) (if 
fail (warn "Unable to activate package `%s'.\nRequired package `%s-%s' is 
unavailable" package (car fail) (package-version-join (cadr fail))) 
(package-activate-1 pkg-vec)))))
  (let ((pkg-descs (cdr (assq package package-alist)))) (while (if pkg-descs 
(progn (let ((available-version (progn ... ...))) (or (package-disabled-p 
package available-version) (package-built-in-p package available-version))))) 
(setq pkg-descs (cdr pkg-descs))) (cond ((null pkg-descs) (package-built-in-p 
package)) ((and (memq package package-activated-list) (not force)) t) (t (let* 
((pkg-vec (car pkg-descs)) (fail (catch (quote dep-failure) (let ... ...)))) 
(if fail (warn "Unable to activate package `%s'.\nRequired package `%s-%s' is 
unavailable" package (car fail) (package-version-join (cadr fail))) 
(package-activate-1 pkg-vec))))))
  package-activate(auctex)
  (let ((elt (car --dolist-tail--))) (package-activate (car elt)) (setq 
--dolist-tail-- (cdr --dolist-tail--)))
  (while --dolist-tail-- (let ((elt (car --dolist-tail--))) (package-activate 
(car elt)) (setq --dolist-tail-- (cdr --dolist-tail--))))
  (let ((--dolist-tail-- package-alist)) (while --dolist-tail-- (let ((elt (car 
--dolist-tail--))) (package-activate (car elt)) (setq --dolist-tail-- (cdr 
--dolist-tail--)))))
  (if no-activate nil (let ((--dolist-tail-- package-alist)) (while 
--dolist-tail-- (let ((elt (car --dolist-tail--))) (package-activate (car elt)) 
(setq --dolist-tail-- (cdr --dolist-tail--))))))
  package-initialize()
  (lambda nil (setq package-archives (append (quote (("org" . 
"http://orgmode.org/elpa/";) ("melpa" . "http://melpa.milkbox.net/packages/";))) 
package-archives)) (package-initialize) (custom-declare-variable (quote 
leuven-elpa-packages) (quote (quote (ace-jump-mode auctex auto-complete bbdb 
bookmark+ boxquote calfw circe company csv-mode dictionary dired+ dired-single 
ess fill-column-indicator flycheck fuzzy git-commit-mode graphviz-dot-mode helm 
htmlize idle-require info+ interaction-log ledger-mode leuven-theme multi-term 
multiple-cursors pager powerline rainbow-mode redo+ tidy unbound yasnippet))) 
"A list of packages to ensure are installed at Emacs startup." :group (quote 
emacs-leuven) :type (quote (repeat (string)))) (defalias (quote 
leuven--missing-elpa-packages) (function (lambda nil "List packages to install 
which are neither built-in nor already installed." (let (missing-elpa-packages) 
(let ((--dolist-tail-- leuven-elpa-packages) pkg) (while --dolist-tail-- (setq 
pkg ...) (if ... nil ...) (setq --dolist-tail-- ...))) 
missing-elpa-packages)))) (let ((missing-elpa-packages 
(leuven--missing-elpa-packages))) (if missing-elpa-packages (progn 
(package-refresh-contents) (let ((--dolist-tail-- missing-elpa-packages) pkg) 
(while --dolist-tail-- (setq pkg (car --dolist-tail--)) (if (yes-or-no-p ...) 
(condition-case nil ... ...) (message ... pkg) (sit-for 1.5)) (setq 
--dolist-tail-- (cdr --dolist-tail--))))))) (add-hook (quote 
package-menu-mode-hook) (function (lambda nil (setq tabulated-list-format 
[("Package" 28 package-menu--name-predicate) ("Version" 14 nil) ("Status" 10 
package-menu--status-predicate) ("Description" 0 nil)]) 
(tabulated-list-init-header)))))()
  [...]
  eval-buffer(#<buffer  *load*-59828> nil 
"d:/Users/fni/src/emacs-leuven/emacs-leuven.el" nil t)  ; Reading at buffer 
position 16581
  load-with-code-conversion("d:/Users/fni/src/emacs-leuven/emacs-leuven.el" 
"d:/Users/fni/src/emacs-leuven/emacs-leuven.el" nil t)
  require(emacs-leuven)
  eval-buffer(#<buffer  *load*> nil "d:/Users/fni/.emacs.d/init.el" nil t)  ; 
Reading at buffer position 4384
  load-with-code-conversion("d:/Users/fni/.emacs.d/init.el" 
"d:/Users/fni/.emacs.d/init.el" t t)
  load("d:/Users/fni/.emacs.d/init" t t)
--8<---------------cut here---------------end--------------->8---

I don't understand this, as there *is* a tex-site.el file in there:

--8<---------------cut here---------------start------------->8---
  d:/Users/fni/.emacs.d/elpa/auctex-11.87.7:
  total used in directory 3872 available 49916672
  drwxrwxrwx  1 Fabrice None    8192 2014-09-02 11:46 ./
  drwxrwxrwx  1 Fabrice None    8192 2014-09-05 17:35 ../
  drwxrwxrwx  1 Fabrice None    4096 2014-09-02 11:46 doc/
  drwxrwxrwx  1 Fabrice None    8192 2014-09-02 11:46 images/
  drwxrwxrwx  1 Fabrice None    4096 2014-09-02 11:46 latex/
  drwxrwxrwx  1 Fabrice None   40960 2014-09-02 11:46 style/
  -rw-rw-rw-  1 Fabrice None      93 2014-09-02 11:46 .elpaignore
  -rw-rw-rw-  1 Fabrice None     406 2014-09-02 11:46 .gitignore
  -rw-rw-rw-  1 Fabrice None   10894 2014-09-02 11:46 auctex-autoloads.el
  -rw-rw-rw-  1 Fabrice None     272 2014-09-02 11:46 auctex-autoloads.el~
  -rw-rw-rw-  1 Fabrice None     181 2014-09-02 11:46 auctex-pkg.el
  -rw-rw-rw-  1 Fabrice None     639 2014-09-02 11:46 auctex-pkg.elc
  -rw-rw-rw-  1 Fabrice None    1193 2014-09-02 11:46 auctex.el
  [...]
  -rw-rw-rw-  1 Fabrice None    5773 2014-09-02 11:46 tex-site.el
  -rw-rw-rw-  1 Fabrice None    4164 2014-09-02 11:46 tex-site.elc
  -rw-rw-rw-  1 Fabrice None   11618 2014-09-02 11:46 tex-style.el
  -rw-rw-rw-  1 Fabrice None    9172 2014-09-02 11:46 tex-style.elc
  -rw-rw-rw-  1 Fabrice None    4147 2014-09-02 11:46 tex-wizard.el
  -rw-rw-rw-  1 Fabrice None    3285 2014-09-02 11:46 tex-wizard.elc
  -rw-rw-rw-  1 Fabrice None  203303 2014-09-02 11:46 tex.el
  -rw-rw-rw-  1 Fabrice None  169620 2014-09-02 11:46 tex.elc
  -rw-rw-rw-  1 Fabrice None   16035 2014-09-02 11:46 texmathp.el
  -rw-rw-rw-  1 Fabrice None    9857 2014-09-02 11:46 texmathp.elc
  -rw-rw-rw-  1 Fabrice None   83399 2014-09-02 11:46 toolbar-x.el
  -rw-rw-rw-  1 Fabrice None   53221 2014-09-02 11:46 toolbar-x.elc
--8<---------------cut here---------------end--------------->8---

And launching Emacs 24.3.1 -- with the same init.el file and the same
package directory -- runs OK.

Any idea?

Best regards,
Fabrice