[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shel
From: |
Noam Postavsky |
Subject: |
bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args |
Date: |
Tue, 21 Oct 2014 21:12:27 -0400 |
On Thu, Oct 16, 2014 at 5:30 PM, Noam Postavsky
<npostavs@users.sourceforge.net> wrote:
> On Thu, Oct 16, 2014 at 1:06 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> GNU Make overcomes this by detecting these cases, and invoking
>> CreateProcess in a special way (NULL as the first argument), see the
>> function process_begin there, around line 710 of sub_proc.c in the GNU
>> Make sources. If you can come up with a way to do the same in Emacs,
>> by some suitable patch to cmdproxy.c, such a patch will be welcome
>> (assuming either the patch is small, or you will agree to sign legal
>> papers necessary for submitting substantial patches to FSF projects).
>
> I'll take a look (btw I have already signed for Emacs).
Patching cmdproxy.c fixes the call-process-shell-command case:
(call-process-shell-command
"\"c:/path with space/foo-bar.bat\" \"x &y\"" nil '(t t) t)
To fix the call-process case:
(call-process
"c:/path with space/foo-bar.bat" nil '(t t) t "x &y")
required a patch to w32proc.c. This is my first patch to Emacs proper;
hopefully I got everything in the right format.
bat-quote.ChangeLog
Description: Binary data
bat-quote.patch
Description: Binary data
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Noam Postavsky, 2014/10/16
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Eli Zaretskii, 2014/10/16
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Stefan Monnier, 2014/10/16
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Noam Postavsky, 2014/10/16
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Eli Zaretskii, 2014/10/16
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Noam Postavsky, 2014/10/16
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args,
Noam Postavsky <=
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Eli Zaretskii, 2014/10/22
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Noam Postavsky, 2014/10/22
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Eli Zaretskii, 2014/10/23
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Eli Zaretskii, 2014/10/25
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Noam Postavsky, 2014/10/25
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Stefan Monnier, 2014/10/16
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Noam Postavsky, 2014/10/16
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Stefan Monnier, 2014/10/16
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Eli Zaretskii, 2014/10/17
- bug#18745: 24.3; MS Windows, `call-process-shell-command' fails on `shell-quote-argument'ed bat file with quoted args, Eli Zaretskii, 2014/10/17