bug#19619: 25.0.50; Fullheight frames in daemonized emacsen are wrong width

[Stephen Berman]

On Mon, 09 Feb 2015 10:31:19 +0100 martin rudalics <rudalics@gmx.at> wrote:

>> The bug was that the combination of (i) adding the frame
>> parameter (fullscreen . fullheight),
>
> ... adding to `default-frame-alist', `initial-frame-alist'?

I used modify-frame-parameters.

>> (ii) customizing tool-bar-style to
>> 'left
>
> `tool-bar-style' or the `tool-bar-position' parameter?

The latter, sorry for the confusion.

>> and (iii) calling tool-bar-add-item or tool-bar-add-item-from-menu
>> resulted in lines longer than window-width wrapping one column too
>> soon.  Again, with current master, this bug is no longer reproducible.
>> So thanks for the prescience (even if unintended)!
>
> Sheer luck, probably.  Does the problem already happen with Emacs 24.5?

It does not happen with my latest build from the emacs-24 branch.  (That
does not use a toolkit scroll bar, unlike my builds from master, though I
guess that isn't relevant here.)

> And what happens with a fullwidth frame and the toolbar orthogonally to
> where it is now?

Do you mean using the parameter (fullscreen . fullboth) and tool bar on
the left?  If so, the result is the same in master with and without you
recent patch: there's a bit of space between the last character and the
right fringe, but less than one column's worth.

Although, with your patch, I no longer observe the problem, in case you
want to do some ex post facto forensics, below is the minimal recipe I
came up with to show the problem.  Do emacs -Q in a build from master
without your patch, evaluate the code and then type `M-x srb-test'.

Steve Berman

(defun srb-test ()
  "Test display of rightmost column."
  (interactive)
  (let ((buf (generate-new-buffer "*srb test*")))
    (with-current-buffer buf
      (insert "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do 
eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim 
veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo 
consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse 
cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non 
proident, sunt in culpa qui officia deserunt mollit anim id est laborum.")
      (srb-test-mode))
    (switch-to-buffer buf)))

(defvar srb-test-toolbar
  (let ((tool-bar-map (make-sparse-keymap)))
    (tool-bar-add-item nil nil nil)
    tool-bar-map))

(defvar srb-test-mode-map
  (let ((map (make-sparse-keymap)))
    (define-key map [menu-bar] (make-sparse-keymap))
    map)
  "Keymap for `srb-test-mode'.")

(define-derived-mode srb-test-mode nil "srb test"
  "Mode to test display of rightmost column."
  (modify-frame-parameters nil '((fullscreen . fullheight)))
  (custom-set-variables '(tool-bar-position (quote left)))
  (setq-local tool-bar-map srb-test-toolbar))