[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20687: 25.0.50; `perform-replace' should invoke a key that you have
From: |
Juri Linkov |
Subject: |
bug#20687: 25.0.50; `perform-replace' should invoke a key that you have bound in `query-replace-map' |
Date: |
Mon, 01 Jun 2015 23:53:05 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) |
> You can bind any key you like in `query-replace-map'. But
> `perform-replace', in effect, hard-codes the keys that it recognizes.
>
> This is not necessary. You shbould be able to bind a new key in that
> map to some command, and have `perform-replace' invoke that command.
>
> All that's required for this is to add another `cond' clause, just
> before the final `t' (otherwise) clause, to do this:
>
> (cond
> ...
> (def (call-interactively def)) ; User-defined key - invoke it.
> (t
> ;; Note: we do not need to treat `exit-prefix'
> ;; specially here, since we reread
> ;; any unrecognized character.
> ...))
>
> It seems silly for the code to be written like it is. We already look
> up the key you press in the q-r keymap. If we find a DEF that is not
> one of those predefined by Emacs then we ignore it? That makes no sense
> (to me).
Could you please send an example of your custom keybindings in
`query-replace-map' that currently don't work.
- bug#20687: 25.0.50; `perform-replace' should invoke a key that you have bound in `query-replace-map',
Juri Linkov <=