[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20783: 25.0.50; [PATCH] byte-to-position has internal off-by-one bug
|
From: |
Wolfgang Jenkner |
|
Subject: |
bug#20783: 25.0.50; [PATCH] byte-to-position has internal off-by-one bug |
|
Date: |
Wed, 17 Jun 2015 14:19:10 +0200 |
|
User-agent: |
Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (berkeley-unix) |
Version: 25.1
On Thu, Jun 11 2015, Eli Zaretskii wrote:
> Works for me, thanks. But please add a comment there about
> BYTE_TO_CHAR expecting byte positions that are on a character
> boundary, so that the reason for the loop is clear.
Done and pushed.
However, I didn't follow my own suggestion of adding a remark to the
comment above BYTE_TO_CHAR, after all, as it is true for most macros or
functions with a byte position argument, so adding such a comment to
just one of them could be confusing, I think.
Thank you for steering this change in the right direction.