[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#19829: 25.0.50; Design of commands operating on rectangular regions
From: |
Stefan Monnier |
Subject: |
bug#19829: 25.0.50; Design of commands operating on rectangular regions |
Date: |
Tue, 30 Jun 2015 22:29:32 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
> Here is a composite patch with implementation of rectangular regions
> based on three different use cases:
Looks pretty good, thanks.
> +(defun region ()
> + `(region
> + (positions ,@(funcall region-extract-function 'positions))))
I don't think we want such a short name. How 'bout `region-boundaries'?
Also, why `(region (positions ,@<foo>)) rather than something simpler
like `(region ,@<foo>)?
> -(defun query-replace (from-string to-string &optional delimited start end
> backward)
> +(defun query-replace (from-string to-string &optional delimited start end
> backward region)
[...]
> + (if (use-region-p) (region-beginning))
> + (if (use-region-p) (region-end))
> + (nth 3 common)
> + (if (use-region-p) (region)))))
I think we should re-use one of START or END rather than add a REGION argument.
Stefan