[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#17453: Framework extending window functions for Follow Mode (etc.).
From: |
Alan Mackenzie |
Subject: |
bug#17453: Framework extending window functions for Follow Mode (etc.). |
Date: |
Thu, 12 Nov 2015 22:15:24 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Hello, Juri.
On Thu, Nov 12, 2015 at 02:52:56AM +0200, Juri Linkov wrote:
> >> > I posted the essence of the framework, as it now is, in a (cut down)
> >> > patch at the beginning of this thread. I have complete patches for both
> >> > the framework and isearch.el available. Together, they are really too
> >> > big to post on emacs-devel.
> >> Could you put them on a branch then?
> > I've created the branch scratch/follow in savannah, with both the new
> > framework and the proposed changes to isearch.el.
> Thanks, I'm looking at your changes, and also Cc'ing Martin in the hope
> that Martin could review your window-related changes as well.
Thanks.
> PS: one immediate question - why do you need a new function
> isearch-call-message
> when at the top of this thread Stefan asked you to replace this code with
> (funcall (or isearch-message-function #'isearch-message) ,cqh ,ellip)
> and even to change isearch-message-function to default to isearch-message
> rather than to nil.
isearch-call-message is actually a macro. It's exists because it's
invoked several times from the rest of the code, and is cleaner this way.
Stefan's request just slipped my memory. It is a relatively minor
stylistic thing, of little consequence. At the time he requested it, he
had lots of far more important criticisms to make. But I could change
it now, no problem.
--
Alan Mackenzie (Nuremberg, Germany).
- bug#17453: Framework extending window functions for Follow Mode (etc.)., (continued)
- bug#17453: Framework extending window functions for Follow Mode (etc.)., Juri Linkov, 2015/11/12
- bug#17453: Framework extending window functions for Follow Mode (etc.)., Alan Mackenzie, 2015/11/17
- bug#17453: Framework extending window functions for Follow Mode (etc.)., Juri Linkov, 2015/11/17
- bug#17453: Framework extending window functions for Follow Mode (etc.)., Alan Mackenzie, 2015/11/18
- bug#17453: Framework extending window functions for Follow Mode (etc.)., Alan Mackenzie, 2015/11/18
- bug#17453: Framework extending window functions for Follow Mode (etc.)., Juri Linkov, 2015/11/18
- bug#17453: Framework extending window functions for Follow Mode (etc.)., Alan Mackenzie, 2015/11/25
- bug#17453: Framework extending window functions for Follow Mode (etc.)., Juri Linkov, 2015/11/26
- bug#17453: Framework extending window functions for Follow Mode (etc.)., Alan Mackenzie, 2015/11/30
- bug#17453: Framework extending window functions for Follow Mode (etc.)., Juri Linkov, 2015/11/30
- bug#17453: Framework extending window functions for Follow Mode (etc.).,
Alan Mackenzie <=