[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy pro
From: |
Lars Ingebrigtsen |
Subject: |
bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy properly |
Date: |
Fri, 25 Dec 2015 22:31:26 +0100 |
User-agent: |
Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) |
lo2net <fangtao0901@gmail.com> writes:
> PS: If without gnutls support, it needs to be modified to use external
> program with https via proxy support(e.g. openssl s_client post-May 2015
> release version:
> http://rt.openssl.org/Ticket/Display.html?id=2651) other than just throw an
> error. But I think very few people will need this since this bug report
> stayed with outstanding status for such a long time.
>
> Here is the patch:
I don't use proxies, so I can't test this, but looking at the code
quickly, it looks good. (But see comments below on style.)
Do you have FSF copyright assignments for Emacs on file?
> - (let ((proc (url-open-stream host buf host port gateway-method)))
> + (let ((proc (url-open-stream host buf (if url-using-proxy (url-host
> url-using-proxy) host) (if url-using-proxy (url-port url-using-proxy) port)
> gateway-method)))
Lines should preferably not be longer than 80 characters.
> + (url-request-data url-http-data)
> + (url-using-proxy (url-find-proxy-for-url
> url-current-object (url-host url-current-object)))
> + )
Don't put closing parentheses on separate lines -- they should be on the
previous line.
> - buffer))
> + (process-send-string connection (url-http-create-request))
> + )
> + )
> + )
> + ))
And ditto. :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy properly,
Lars Ingebrigtsen <=