bug#22453: [PATCH] Support for switching to hexl-mode from image mode

[Eli Zaretskii]

> Date: Sun, 24 Jan 2016 20:59:41 +0600
> From: Alexander Kuleshov <kuleshovmail@gmail.com>
> Cc: Alexander Kuleshov <kuleshovmail@gmail.com>, 22453@debbugs.gnu.org
> 
> >   . Please provide a ChangeLog-style commit log message for the
> >     changes (some details are in CONTRIBUTE).
> 
> Ok, will do, just one question. where do I need add it? As you may
> see I added some description to the commit message. Do I need to
> do something additional? But anyway, I will look into CONTRIBUTE.

It is best to make a local commit to your private branch, write the
commit log message using "C-x 4 a", and then produce the patch using
"git format-patch".

> > > +(defun image-toggle-hex-display ()
> > > +  "Toggle between image and text display.
> > > +If the current buffer is displaying an image file as an image,
> > > +call `image-mode-as-hex' to switch to text.  Otherwise, display
> > > +the image by calling `image-mode'."
> > 
> > It is best to avoid referring to another command in a doc string, if
> > you can avoid that.  In this case, the reference doesn't add any
> > useful information, so I think it should be deleted.
> 
> Are you about `image-mode-as-hex`? I've copied it from the 
> image-toggle-display
> doc string. Do we need to delete it there too?

Yes, please delete the reference in both doc strings.

> > Last, but not least, I think this contribution is too large to accept
> > without legal paperwork.  I don't see your copyright assignment on
> > file; would you like me to send you the form so you could start the
> > paperwork rolling?
> 
> Yes, sure.

Sent off-list.

Thanks.