[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22923: [PATCH] Support completion of attribute values in CSS mode
From: |
Dmitry Gutov |
Subject: |
bug#22923: [PATCH] Support completion of attribute values in CSS mode |
Date: |
Sun, 6 Mar 2016 21:10:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
Hi Simen,
On 03/06/2016 03:53 PM, Simen Heggestøyl wrote:
I've finally gotten around to implement property value completion in
CSS mode. I've been using the attached patch privately for some weeks
now, and it seems to me that it works well.
I haven't tried it, but it looks good overall.
- The new `css--property-values' function is very similar to
`company-css-property-values', but it has been updated to support
following completion candidates further from the value class
completion lists.
Doesn't the latter allow for several indirections? It seems to me the
two functions are equivalent.
One question: is there a reason to do the (symbol-name value) conversion
before doing the css--property-values lookup?
Maybe the css-value-class-alist should have symbol keys, not strings.
- Completion a function name will no longer put commas between the
parenthesis. My reason for this is that many CSS functions take a
variable number of arguments. For instance, the `translate' function
is completed by company-css to `translate(,)', but `translate' can
take only one argument too, so the completion is misleading. Also,
there are functions that support an arbitrary number of
arguments. Instead of trying to support this, I've made every
function name complete to just `function()'. I think having ElDoc
support for CSS functions would be good for making it easier to
remember which arguments functions take.
Sounds good.
- bug#22923: [PATCH] Support completion of attribute values in CSS mode, Simen Heggestøyl, 2016/03/06
- bug#22923: [PATCH] Support completion of attribute values in CSS mode,
Dmitry Gutov <=
- bug#22923: [PATCH] Support completion of attribute values in CSS mode, Simen Heggestøyl, 2016/03/09
- bug#22923: [PATCH] Support completion of attribute values in CSS mode, Dmitry Gutov, 2016/03/10
- bug#22923: [PATCH] Support completion of attribute values in CSS mode, Simen Heggestøyl, 2016/03/19
- bug#22923: [PATCH] Support completion of attribute values in CSS mode, Dmitry Gutov, 2016/03/19
- bug#22923: [PATCH] Support completion of attribute values in CSS mode, Simen Heggestøyl, 2016/03/21
- bug#22923: [PATCH] Support completion of attribute values in CSS mode, Dmitry Gutov, 2016/03/21
- bug#22923: [PATCH] Support completion of attribute values in CSS mode, Simen Heggestøyl, 2016/03/23
- bug#22923: [PATCH] Support completion of attribute values in CSS mode, Dmitry Gutov, 2016/03/23