bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16984: dired-do-rename susceptible to .../~/... hijack


From: npostavs
Subject: bug#16984: dired-do-rename susceptible to .../~/... hijack
Date: Mon, 31 Oct 2016 20:42:22 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Michael Albinus <michael.albinus@gmx.de> writes:
>>  
>> +           (not (let ((handler (find-file-name-handler
>> +                                filename 'substitute-in-file-name)))
>> +                  (and handler
>> +                       (funcall handler 'substitute-in-file-name 
>> filename)))))
>
> I would rather use (not (file-remote-p file-name))

Okay.

Attachment: v3-0001-Quote-filenames-containing-in-prompts.patch
Description: patch v3

>
> This fixes the problem for local file names, but not for remote
> ones. "/ssh:user@host:/path/~/file" would still be expanded to something
> like "/ssh:user@host:/home/user/file". Well, better than nothing.
>
> What do people think to use the "/:" prefix also for the local part of
> remote file names? Then one could use "/ssh:user@host:/:/path/~/file",
> making substitute-in-file-name a noop.

Makes sense to me.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]