[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25677: [PATCH 01/22] oldXMenu: add missing #include <string.h>
From: |
Michal Nazarewicz |
Subject: |
bug#25677: [PATCH 01/22] oldXMenu: add missing #include <string.h> |
Date: |
Wed, 15 Feb 2017 17:13:13 +0100 |
User-agent: |
Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/26.0.50.1 (x86_64-unknown-linux-gnu) |
On Fri, Feb 10 2017, Michal Nazarewicz wrote:
> Some of the files in oldXMenu use functions from string.h without
> including that header which results in compile warnings:
>
> ChgPane.c:46:5: warning: implicit declaration of function ‘strlen’
> ChgPane.c:46:20: warning: incompatible implicit declaration of
> built-in function ‘strlen’
> ChgSel.c:62:2: warning: implicit declaration of function ‘strlen’
> ChgSel.c:62:17: warning: incompatible implicit declaration of built-in
> function ‘strlen’
> Create.c:220:5: warning: implicit declaration of function ‘strcmp’
> InsPane.c:65:5: warning: implicit declaration of function ‘strlen’
> InsPane.c:65:20: warning: incompatible implicit declaration of
> built-in function ‘strlen’
> InsSel.c:68:5: warning: implicit declaration of function ‘strlen’
> InsSel.c:68:20: warning: incompatible implicit declaration of built-in
> function ‘strlen’
> InsSel.c:75:5: warning: implicit declaration of function ‘strcmp’
>
> Add the necessary ‘#include <string.h>’.
>
> oldXMenu/ChgPane.c, oldXMenu/ChgSel.c, oldXMenu/Create.c, oldXMenu/InsPane.c,
> oldXMenu/InsSel.c: add missing #include <string.h>
Pushed.
> ---
> oldXMenu/ChgPane.c | 1 +
> oldXMenu/ChgSel.c | 1 +
> oldXMenu/Create.c | 1 +
> oldXMenu/InsPane.c | 1 +
> oldXMenu/InsSel.c | 1 +
> 5 files changed, 5 insertions(+)
>
> Unless there are some objections I’ll commit this in a few days.
>
> diff --git a/oldXMenu/ChgPane.c b/oldXMenu/ChgPane.c
> index d2977b73faf..733f65950f5 100644
> --- a/oldXMenu/ChgPane.c
> +++ b/oldXMenu/ChgPane.c
> @@ -14,6 +14,7 @@
> */
>
> #include "XMenuInt.h"
> +#include <string.h>
>
> int
> XMenuChangePane(register XMenu *menu, register int p_num, char *label)
> diff --git a/oldXMenu/ChgSel.c b/oldXMenu/ChgSel.c
> index d24e61f56d5..5a46b5cf587 100644
> --- a/oldXMenu/ChgSel.c
> +++ b/oldXMenu/ChgSel.c
> @@ -14,6 +14,7 @@
> */
>
> #include "XMenuInt.h"
> +#include <string.h>
>
> int
> XMenuChangeSelection(Display *display, register XMenu *menu, register int
> p_num, register int s_num, char *data, int data_sw, char *label, int label_sw)
> diff --git a/oldXMenu/Create.c b/oldXMenu/Create.c
> index 0e72a2d2e58..a0913685365 100644
> --- a/oldXMenu/Create.c
> +++ b/oldXMenu/Create.c
> @@ -31,6 +31,7 @@ along with this program. If not, see
> <http://www.gnu.org/licenses/>. */
>
> #include "XMenuInt.h"
> #include <stdlib.h>
> +#include <string.h>
>
> #ifdef EMACS_BITMAP_FILES
> #include "../src/bitmaps/dimple1.xbm"
> diff --git a/oldXMenu/InsPane.c b/oldXMenu/InsPane.c
> index d8470f3a5bf..da92f49aa77 100644
> --- a/oldXMenu/InsPane.c
> +++ b/oldXMenu/InsPane.c
> @@ -15,6 +15,7 @@
> */
>
> #include "XMenuInt.h"
> +#include <string.h>
>
> int
> XMenuInsertPane(register XMenu *menu, register int p_num, char *label, int
> active)
> diff --git a/oldXMenu/InsSel.c b/oldXMenu/InsSel.c
> index 66f4968197d..f5380437958 100644
> --- a/oldXMenu/InsSel.c
> +++ b/oldXMenu/InsSel.c
> @@ -14,6 +14,7 @@
> */
>
> #include "XMenuInt.h"
> +#include <string.h>
>
> int
> XMenuInsertSelection(register XMenu *menu, register int p_num, register int
> s_num, char *data, char *label, int active)
> --
> 2.11.0.483.g087da7b7c-goog
>
--
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»