[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25426: Copyright Assignment Completed
From: |
Eli Zaretskii |
Subject: |
bug#25426: Copyright Assignment Completed |
Date: |
Sat, 06 May 2017 10:50:31 +0300 |
> Date: Sat, 06 May 2017 10:16:58 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 25426@debbugs.gnu.org
>
> Would people please look at the proposed patch and comment? I will
> push to master in a few days if there are no comments.
Some minor comments of my own:
> 2017-01-12 Andrew Robbins <contact@andrewrobbins.info>
>
> * lisp/net/net-utils.el (ffap-string-at-point): Removed due to
> 'net-utils-machine-at-point' obviating this autoloaded function.
> (dig-program-options): New customization variable.
> (nslookup-host, dns-lookup-host, run-dig): Can now specify optional
> name server argument interactively (by prefix arg) & noninteractively.
Please mention the bug number in the log message, for reference.
> +(defcustom dig-program-options nil
> + "Options for the dig program."
> + :group 'net-utils
> + :type '(repeat string))
When you introduce new defcustoms, please provide a :version tag whose
value is the first Emacs version where this defcustom will be
available (26.1 in this case).
> +(defun nslookup-host (host &optional name-server)
> + "Look up the DNS information for HOST (name or IP address).
> +When called interactively, DNS resolver NAME-SERVER may be specified
> +by passing the function a prefix argument."
Our standard wording for such optional behavior is like this:
Look up the DNS information for HOST (name or IP address).
Optional argument NAME-SERVER says which server to use for
DNS resolution.
Interactively, prompt for NAME-SERVER if invoked with prefix argument.
> +(defun dns-lookup-host (host &optional name-server)
> + "Look up the DNS information for HOST (name or IP address).
> +When called interactively, DNS resolver NAME-SERVER may be specified
> +by passing the function a prefix argument."
Same here.
> +(defun run-dig (host &optional name-server)
> + "Look up the DNS information for HOST (name or IP address).
> +When called interactively, DNS resolver NAME-SERVER may be specified
> +by passing the function a prefix argument."
And here.
Finally, please add a NEWS entry to describe these new features.
Thanks for working on this.