bug#27066: 25.1; dired unsafe variables

[Francesco Potortì]

>> >Please suggest how to improve the existing docs.
>> 
>> The warning message should not say that risky variables are present in the
>> directory: that makes sense only if you know where to look.  When
>> reading that message, I thought about some bug somewhere.
>> 
>> The warning message should name the file where the offending variables
>> were found, instead.
>
>Patches are welcome to add the file name.  AFAICT, the function that
>actually applies the variables doesn't know on which file the
>variables were found, as there could be more than one of them, and
>they all are read to produce a list of variables, before the
>variables' values are applied.

First, sorry to say this, there is no hope I could ever create a patch
of tht kind.

Second, I already suspected that.  Unfortunately, I fear that in fact
this is important.  It makes no sense to me to know that the directory
contains some risky variables.  I personally know what are file-local
variables.  Probably a minority of Emacs users know that.  But I had no
idea that directory-local risky variables existed.

>> >Perhaps we should offer an option to ask the question you mentioned,
>> >but I think in general it will annoy too much.
>> 
>> I don't know.  It's a relatively recent innovation, and I bet very few
>> users have ever stumbled into it.
>
>Well, not too recent: it was introduced in Emacs 23.1, 8 years ago.
>Time flies...

Yes.  Time flies :)

But that is not something that you are bound to see.  You only notice it
when someone else us uses it and you download a tree where that's used.
A pretty unlikely situation, all in all.  I understand that this is a
matter of (personal?) judgement, but it is an uncommon corner case.  And
given the problem above, when you don't even know where that variables
come from, it should not be treated lightly, in my opinion.