[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28809: 26.0.90; Error running timer ‘image-dired-thumb-queue-run’
From: |
Eli Zaretskii |
Subject: |
bug#28809: 26.0.90; Error running timer ‘image-dired-thumb-queue-run’ |
Date: |
Fri, 13 Oct 2017 17:33:51 +0300 |
> From: Davor Rotim <rotim.davor@gmail.com>
> Date: Fri, 13 Oct 2017 15:33:24 +0200
>
> Started with emacs -Q, opened a dired buffer, navigated to an image and
> pressed C-t .
> on it (image-dired-display-thumb) to generate a thumbnail. That leaves me
> with only an error message:
>
> Error running timer ‘image-dired-thumb-queue-run’: (range-error "floor"
> 1505334534.0059688)
Mark, could you please look at this? You changed the code to use
floor instead of rounding via format "%.0f", but floor returns an
Emacs integer which can overflow on 32-bit hosts for large time
values, as happens here. I think we should use ffloor instead, and if
that produces a decimal point, eliminate it with "%.0f" format.
TIA