[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-sele
From: |
Eli Zaretskii |
Subject: |
bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection |
Date: |
Sat, 14 Oct 2017 09:56:20 +0300 |
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Cc: Eli Zaretskii <eliz@gnu.org>, 28631@debbugs.gnu.org
> Date: Fri, 13 Oct 2017 22:09:49 -0400
>
> >> That patch only has affect during winner-undo, no?
> > I think so.
>
> Actually, I thought about it a bit more, and realized it could also
> affect things like post-command hooks that are run after winner-undo.
>
> >> Maybe only the (setf (winner-active-region) (cdr entry)) part should be
> >> skipped?
> > We need to ban
> > (set-mark (car entry))
> > as well, because it updates the primary selection.
>
> Ah, okay.
>
> > I assume if someone have set select-enable-primary, then she
> > probably doesn't want winner-undo to change her selection.
>
> Seems reasonable.
Please push to emacs-26 in a few days, if no comments or objections
surface.
Thanks.
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection, Tino Calancha, 2017/10/11
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection, Noam Postavsky, 2017/10/11
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection, Tino Calancha, 2017/10/11
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection, Noam Postavsky, 2017/10/12
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection, Tino Calancha, 2017/10/12
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection, Eli Zaretskii, 2017/10/13
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection, Tino Calancha, 2017/10/13
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection, Noam Postavsky, 2017/10/13
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection, Tino Calancha, 2017/10/13
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection, Noam Postavsky, 2017/10/13
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection,
Eli Zaretskii <=
- bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection, Tino Calancha, 2017/10/17