[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28587: 26.0.60; Don't write object name strings in object-write meth
From: |
Stefan Monnier |
Subject: |
bug#28587: 26.0.60; Don't write object name strings in object-write method |
Date: |
Sat, 21 Oct 2017 23:29:00 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
> If we're going to ignore them, we might as well not write them to begin
> with.
Agreed.
> --- a/lisp/emacs-lisp/eieio-base.el
> +++ b/lisp/emacs-lisp/eieio-base.el
> @@ -255,8 +255,11 @@ eieio-persistent-convert-list-to-object
> Note: This function recurses when a slot of :type of some object is
> identified, and needing more object creation."
> (let* ((objclass (nth 0 inputlist))
> - ;; (objname (nth 1 inputlist))
> - (slots (nthcdr 2 inputlist))
> + ;; Earlier versions of `object-write' added a string name for
> + ;; the object, now obsolete.
> + (slots (nthcdr
> + (if (stringp (nth 1 inputlist)) 2 1)
> + inputlist))
> (createslots nil)
> (class
> (progn
This looks good, feel free to install it into `master'.
> diff --git a/lisp/emacs-lisp/eieio.el b/lisp/emacs-lisp/eieio.el
> index 75f1097acf..448d5e6fe2 100644
> --- a/lisp/emacs-lisp/eieio.el
> +++ b/lisp/emacs-lisp/eieio.el
> @@ -874,8 +874,6 @@ eieio-print-depth
> (princ (make-string (* eieio-print-depth 2) ? ))
> (princ "(")
> (princ (symbol-name (eieio--class-constructor (eieio-object-class
> this))))
> - (princ " ")
> - (prin1 (eieio-object-name-string this))
> (princ "\n")
> ;; Loop over all the public slots
> (let ((slots (eieio--class-slots cv))
This is more problematic since data generated with this hunk will be
incompatible with an Emacs which doesn't have the other hunk applied.
So I think this should be conditional on a defcustom and by default this
defcustom should cause the code to still behave as before.
Stefan
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#28587: 26.0.60; Don't write object name strings in object-write method,
Stefan Monnier <=