[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30822: 25.3; python-shell-send-defun sends only one line
From: |
Noam Postavsky |
Subject: |
bug#30822: 25.3; python-shell-send-defun sends only one line |
Date: |
Fri, 06 Apr 2018 22:26:56 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) |
Nitish <nitishch@protonmail.com> writes:
> (when (not arg)
> - (while (and (forward-line -1)
> - (looking-at (python-rx decorator))))
> - (forward-line 1))
> + (while (and
> + ;; Make sure forward-line actually moves Point
> + (eq (forward-line -1) 0)
> + ;; If Point is at a decorator, loop.
> + ;; else, move one line down and exit the loop.
> + (or (looking-at (python-rx decorator))
> + (and (forward-line 1) nil)))))
Thanks. You could drop the comments, since they just repeat what the
code is saying. And, while I know it's fairly common to use `and' and
`or' like that to encode conditionals, perhaps using `if' directly would
minimize the temptation to rephrase it as an "if" statement in English.
- bug#30822: 25.3; python-shell-send-defun sends only one line, Nitish, 2018/04/06
- bug#30822: 25.3; python-shell-send-defun sends only one line,
Noam Postavsky <=
- bug#30822: 25.3; python-shell-send-defun sends only one line, Nitish, 2018/04/06
- bug#30822: 25.3; python-shell-send-defun sends only one line, Noam Postavsky, 2018/04/08
- bug#30822: 25.3; python-shell-send-defun sends only one line, Andreas Röhler, 2018/04/09
- bug#30822: 25.3; python-shell-send-defun sends only one line, Noam Postavsky, 2018/04/09
- bug#30822: 25.3; python-shell-send-defun sends only one line, Andreas Röhler, 2018/04/11
- bug#30822: 25.3; python-shell-send-defun sends only one line, Noam Postavsky, 2018/04/11