bug#30230: 27.0.50; find-face-definition wrong result for default face

[Lars Ingebrigtsen]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Steps to reproduce:
>
> 1. emacs -Q
> 2. M-x find-face-definition RET default RET
>
> Expected result: point at definition of default defface in
> lisp/faces.el.
>
> Actual result: point in docstring of face-spec-recalc defun in
> lisp/faces.el

Yup.

> Some solution suggestions, in order of increasing complexity:
>
> 1. Reword aforementioned docstring to make it look less like a defface,
>    e.g. by replacing parens with brackets.
>
> 2. Replace find-face-regexp in find-function-regexp-alist with a
>    function which repeats the find-face-regexp search until point is
>    actually at a defface.

At least it could look around and see whether it's in a doc string or a
comment, and not return the definition if it's there, I would have
thought?  And without looking at the code, I would imagine that that
shouldn't be very difficult.

> Let me know what you think and whether you would like me to provide a
> patch.

Yes, please patches.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no