bug#20493: 25.0.50; next-error in change-log-mode can hide its buffer

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Date: Tue, 17 Apr 2018 23:55:06 +0300
> Cc: 20493-done@debbugs.gnu.org
> 
> > next-error-function in *compile* or *grep* works in a certain way:
> >
> > - It doesn't open the locations when the *compile* buffer is selected,
> >   it just jumps between them in that buffer.
> >
> > - When *compile* is visible but displayed a different window, pressing
> >   C-x ` will never display the "next error" on top of *compile*. So the
> >   latter always stays visible.
> >
> > Neither is true of change-log-next-error.
> >
> > I think we need more consistency in this.
> 
> This is finally implemented.

Thanks, but I think the documentation that accompanies these changes
should be augmented/improved:

  . next-error-select-buffer should be documented in the Emacs manual
  . the doc string of next-error-select-buffer should be expanded to
    explain the effect of selecting a buffer.  The current text is
    quite cryptic, IMO: "set it as the last used."  The meaning of
    "last used" in this context should be explained.
  . next-error-find-buffer-function should perhaps be mentioned in the
    Emacs manual and/or the ELisp manual.
  . the doc string of next-error-find-buffer-function should describe
    the arguments with which it is called, what possible values it can
    return, and the meaning of each returned value.

TIA