[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26750: [PATCH] add missing keywords to js-mode
From: |
Noam Postavsky |
Subject: |
bug#26750: [PATCH] add missing keywords to js-mode |
Date: |
Sat, 28 Apr 2018 17:08:09 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
forcemerge 26750 31306
quit
Ruslan Bekenev <furyinbox@gmail.com> writes:
> Hi. It is my first contribution.
> I hope everything is correct with this PATCH and submission itself.
> In this patch added two missed keywords to `js--keyword-re` which are `as`
> and `of`.
> `async` and `await` are already there.
Hi, sorry your patch was overlooked for so long. Unfortunately, I think
just adding keywords to js--keyword-re will not quite do the right
thing, based on https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31306#5:
Specially, "as" and "from" should only be highlighted in an import
statement. "of" should only be highlighted in a for statement. Any other
occurrances of "as", "from" and "of" should not be highlighted as they
are legal identifiers outside of import and for statements respectively.
- bug#26750: [PATCH] add missing keywords to js-mode,
Noam Postavsky <=