[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21057: [PATCH] nnimap.el: add support for IMAP namespaces
From: |
Nikolaus Rath |
Subject: |
bug#21057: [PATCH] nnimap.el: add support for IMAP namespaces |
Date: |
Thu, 31 May 2018 12:38:32 +0100 |
Hi,
On Wed, 27 Dec 2017, at 22:10, Lars Ingebrigtsen wrote:
> Looks good, but a couple of niggles:
>
> > +(setq nnimap-namespaces nil)
>
> This should be a defvar, or rather, a defvoo.
>
> [...]
>
> > + (let* ((prefix (cadr (assoc (nnoo-current-server 'nnimap)
> > + nnimap-namespaces)))
> > + (inbox (substring prefix 0 -1)))
>
> And then you could just set nnimap-namespaces without maintaining a
> per-server alist, since that's what the voo machinery does for you
> (switching out variables on a per-server basis).
Updated patches attached (and rebased onto current master).
Best,
-Nikolaus
--
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F
»Time flies like an arrow, fruit flies like a Banana.«
0001-nnimap.el-factor-out-nnimap-group-to-imap.patch
Description: Text Data
0002-nnimap.el-Add-support-for-IMAP-namespaces.patch
Description: Text Data
0003-Turn-nnimap-namespaces-into-a-defvoo-to-make-it-per-.patch
Description: Text Data
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#21057: [PATCH] nnimap.el: add support for IMAP namespaces,
Nikolaus Rath <=